Re: [PATCH] epoll_[p]wait: fix spurious -EINTR on ptrace attach

2013-06-26 Thread Denys Vlasenko
On Tuesday 25 June 2013 22:06, Oleg Nesterov wrote: > > > In order to define a "sigset_t ksigmask" member, > > > > You do not need it. But the reason is not clear until the cleanup. > > I take this back, this is not as simple as I thought... and perhaps even > not right. > > However. Probably you

Re: [PATCH] epoll_[p]wait: fix spurious -EINTR on ptrace attach

2013-06-25 Thread Oleg Nesterov
On 06/25, Oleg Nesterov wrote: > > On 06/25, Denys Vlasenko wrote: > > > > Before this change, epoll_wait and epoll_pwait > > spuriously return with -EINTR on ptrace attach. > > > > By analogy with poll syscall family, epoll_[p]wait should be interruptible > > by signals regardless of SA_RESTART, t

Re: [PATCH] epoll_[p]wait: fix spurious -EINTR on ptrace attach

2013-06-25 Thread Oleg Nesterov
On 06/25, Denys Vlasenko wrote: > > Before this change, epoll_wait and epoll_pwait > spuriously return with -EINTR on ptrace attach. > > By analogy with poll syscall family, epoll_[p]wait should be interruptible > by signals regardless of SA_RESTART, therefore, this change > makes them return -ERES

[PATCH] epoll_[p]wait: fix spurious -EINTR on ptrace attach

2013-06-25 Thread Denys Vlasenko
Before this change, epoll_wait and epoll_pwait spuriously return with -EINTR on ptrace attach. By analogy with poll syscall family, epoll_[p]wait should be interruptible by signals regardless of SA_RESTART, therefore, this change makes them return -ERESTARTNOHAND if timeout has expired. If timeou