Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-23 Thread Gao Xiang
On Wed, Dec 23, 2020 at 08:54:01AM +, Christoph Hellwig wrote: > On Wed, Dec 23, 2020 at 04:48:20PM +0800, Huang Jianan wrote: > > Hi Christoph, > > > > The reason we use dio is because we need to deploy the patch on some early > > kernel versions, and we don't pay much attention to the

Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-23 Thread Christoph Hellwig
On Wed, Dec 23, 2020 at 04:48:20PM +0800, Huang Jianan wrote: > Hi Christoph, > > The reason we use dio is because we need to deploy the patch on some early > kernel versions, and we don't pay much attention to the change of iomap. No, that is never an excuse for upstream development.

Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-23 Thread Huang Jianan
Hi Christoph, The reason we use dio is because we need to deploy the patch on some early kernel versions, and we don't pay much attention to the change of iomap. Anyway, I will study the problem mentioned by Gao Xiang and try to convert the current patch to iomap. Thanks, Jianan On Wed,

Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-22 Thread Christoph Hellwig
On Wed, Dec 23, 2020 at 03:39:01AM +0800, Gao Xiang wrote: > Hi Christoph, > > On Tue, Dec 22, 2020 at 02:22:34PM +, Christoph Hellwig wrote: > > Please do not add new callers of __blockdev_direct_IO and use the modern > > iomap variant instead. > > We've talked about this topic before. The

Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-22 Thread Gao Xiang
Hi Christoph, On Tue, Dec 22, 2020 at 02:22:34PM +, Christoph Hellwig wrote: > Please do not add new callers of __blockdev_direct_IO and use the modern > iomap variant instead. We've talked about this topic before. The current status is that iomap doesn't support tail-packing inline data yet

Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-22 Thread Christoph Hellwig
Please do not add new callers of __blockdev_direct_IO and use the modern iomap variant instead.

Re: [PATCH] erofs: support direct IO for uncompressed file

2020-12-22 Thread Gao Xiang
Hi Jianan, On Mon, Dec 14, 2020 at 10:04:27PM +0800, Huang Jianan wrote: > direct IO is useful in certain scenarios for uncompressed files. > For example, it can avoid double pagecache when use the uncompressed > file to mount upper layer filesystem. > > In addition, another patch adds direct IO

[PATCH] erofs: support direct IO for uncompressed file

2020-12-14 Thread Huang Jianan
direct IO is useful in certain scenarios for uncompressed files. For example, it can avoid double pagecache when use the uncompressed file to mount upper layer filesystem. In addition, another patch adds direct IO test for the stress tool which was mentioned here: