Re: [PATCH] errors with assignments in if

Roel Kluin wrote: > I am not entirely certain about the third one: > > from fs/udf/udf_sb.h: > > #define UDF_SB_VAT(X) ( UDF_SB(X)->s_vat ) > > if it's the desired behavior then I think this should at least be changed to > > UDF_SB_VAT(sb) = udf_iget(sb, ino); > if (!(

[PATCH] errors with assignments in if

I am not entirely certain about the third one: from fs/udf/udf_sb.h: #define UDF_SB_VAT(X) ( UDF_SB(X)->s_vat ) if it's the desired behavior then I think this should at least be changed to UDF_SB_VAT(sb) = udf_iget(sb, ino); if (!(UDF_SB_VAT(sb))) --- Errors with