Re: [PATCH] es1371 pci fix/cleanup

2001-04-23 Thread Jeff Garzik
Marcus Meissner wrote: > Hmm, I think I spotted all places in the probe function. I also return > -ENODEV in case we can't request_region() or request_irq(). > > Some drivers use EBUSY, some ENOMEM, some ENODEV there, is there > any standard return value? request_region/request_mem_region - EBUS

Re: [PATCH] es1371 pci fix/cleanup

2001-04-23 Thread Marcus Meissner
On Mon, Apr 23, 2001 at 11:58:25AM -0400, Jeff Garzik wrote: > Marcus Meissner wrote: > > > > Hi, > > > > This moves pci_enable_device in the es1371 driver before any resource > > access and also replaces the RSRCISIOREGION by just pci_resource_flags > > as suggested by Jeff. > > > > Tested and

Re: [PATCH] es1371 pci fix/cleanup

2001-04-23 Thread Jeff Garzik
Marcus Meissner wrote: > > Hi, > > This moves pci_enable_device in the es1371 driver before any resource > access and also replaces the RSRCISIOREGION by just pci_resource_flags > as suggested by Jeff. > > Tested and verified. > > Ciao, Marcus > > Index: drivers/sound/es1371.c > =

[PATCH] es1371 pci fix/cleanup

2001-04-23 Thread Marcus Meissner
Hi, This moves pci_enable_device in the es1371 driver before any resource access and also replaces the RSRCISIOREGION by just pci_resource_flags as suggested by Jeff. Tested and verified. Ciao, Marcus Index: drivers/sound/es1371.c ===