Re: [PATCH] et131x: use msecs_to_jiffies for conversions

2015-02-11 Thread David Miller
From: Nicholas Mc Guire Date: Wed, 11 Feb 2015 04:27:54 -0500 > This is only an API consolidation and should make things more readable. > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > OK but msecs_to_jiffies(val) is the cleaner solution and handles all > corner cases

Re: [PATCH] et131x: use msecs_to_jiffies for conversions

2015-02-11 Thread Mark Einon
On Wed, Feb 11, 2015 at 04:27:54AM -0500, Nicholas Mc Guire wrote: > This is only an API consolidation and should make things more readable. > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > OK but msecs_to_jiffies(val) is the cleaner solution and handles all > corner

[PATCH] et131x: use msecs_to_jiffies for conversions

2015-02-11 Thread Nicholas Mc Guire
This is only an API consolidation and should make things more readable. Converting milliseconds to jiffies by "val * HZ / 1000" is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases correctly. This is a minor API cleanup only. Signed-off-by: Nicholas Mc

Re: [PATCH] et131x: use msecs_to_jiffies for conversions

2015-02-11 Thread Mark Einon
On Wed, Feb 11, 2015 at 04:27:54AM -0500, Nicholas Mc Guire wrote: This is only an API consolidation and should make things more readable. Converting milliseconds to jiffies by val * HZ / 1000 is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases

Re: [PATCH] et131x: use msecs_to_jiffies for conversions

2015-02-11 Thread David Miller
From: Nicholas Mc Guire hof...@osadl.org Date: Wed, 11 Feb 2015 04:27:54 -0500 This is only an API consolidation and should make things more readable. Converting milliseconds to jiffies by val * HZ / 1000 is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all

[PATCH] et131x: use msecs_to_jiffies for conversions

2015-02-11 Thread Nicholas Mc Guire
This is only an API consolidation and should make things more readable. Converting milliseconds to jiffies by val * HZ / 1000 is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases correctly. This is a minor API cleanup only. Signed-off-by: Nicholas Mc