Re: [PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-05 Thread David Miller
From: Vineet Gupta Date: Fri, 6 Sep 2013 04:24:39 + > On 09/05/2013 11:54 PM, David Miller wrote: >> You should keep the check in the transmit queueing code as a BUG check, >> almost every driver has code of the form (using NIU as an example): ... >> Otherwise queue management bugs are

Re: [PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-05 Thread Vineet Gupta
Hi David, On 09/05/2013 11:54 PM, David Miller wrote: > From: Vineet Gupta > Date: Wed, 4 Sep 2013 18:33:11 +0530 > >> This came out of staring at code due to recent performance fix. >> >> * TX BD reclaim can call netif_wake_queue() once, outside the loop if >> one/more BDs were freed, NO need

Re: [PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-05 Thread David Miller
From: Vineet Gupta Date: Wed, 4 Sep 2013 18:33:11 +0530 > This came out of staring at code due to recent performance fix. > > * TX BD reclaim can call netif_wake_queue() once, outside the loop if > one/more BDs were freed, NO need to do this each iteration. > > * TX need not look at next BD

Re: [PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-05 Thread David Miller
From: Vineet Gupta vineet.gup...@synopsys.com Date: Wed, 4 Sep 2013 18:33:11 +0530 This came out of staring at code due to recent performance fix. * TX BD reclaim can call netif_wake_queue() once, outside the loop if one/more BDs were freed, NO need to do this each iteration. * TX need

Re: [PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-05 Thread Vineet Gupta
Hi David, On 09/05/2013 11:54 PM, David Miller wrote: From: Vineet Gupta vineet.gup...@synopsys.com Date: Wed, 4 Sep 2013 18:33:11 +0530 This came out of staring at code due to recent performance fix. * TX BD reclaim can call netif_wake_queue() once, outside the loop if one/more BDs were

Re: [PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-05 Thread David Miller
From: Vineet Gupta vineet.gup...@synopsys.com Date: Fri, 6 Sep 2013 04:24:39 + On 09/05/2013 11:54 PM, David Miller wrote: You should keep the check in the transmit queueing code as a BUG check, almost every driver has code of the form (using NIU as an example): ... Otherwise queue

[PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-04 Thread Vineet Gupta
This came out of staring at code due to recent performance fix. * TX BD reclaim can call netif_wake_queue() once, outside the loop if one/more BDs were freed, NO need to do this each iteration. * TX need not look at next BD to stop the netif queue. It rather be done in the next tx call, when

[PATCH] ethernet/arc/arc_emac: optimize the Tx/Tx-reclaim paths a bit

2013-09-04 Thread Vineet Gupta
This came out of staring at code due to recent performance fix. * TX BD reclaim can call netif_wake_queue() once, outside the loop if one/more BDs were freed, NO need to do this each iteration. * TX need not look at next BD to stop the netif queue. It rather be done in the next tx call, when