Re: [PATCH] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread Colin Ian King
On 11/05/17 19:16, David Miller wrote: > From: Colin King > Date: Thu, 11 May 2017 18:29:29 +0100 > >> From: Colin Ian King >> >> The error status err is initialized as zero and then being checked >> several times to see if it is less than zero even when it has not >> been updated. Since these c

Re: [PATCH] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread David Miller
From: Colin King Date: Thu, 11 May 2017 18:29:29 +0100 > From: Colin Ian King > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. Since these checks are redundant we can remove these > as well

[PATCH] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread Colin King
From: Colin Ian King The error status err is initialized as zero and then being checked several times to see if it is less than zero even when it has not been updated. Since these checks are redundant we can remove these as well as err and the error exit label err_exit. Detected by CoverityScan,