Re: [PATCH] ethtool: reduce stack usage with clang

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 11:06 AM Michal Kubecek wrote: > > On Thu, Mar 07, 2019 at 10:33:35AM +0100, Arnd Bergmann wrote: > > @@ -2533,7 +2535,7 @@ static int ethtool_set_fecparam(struct net_device > > *dev, void __user *useraddr) > > > > /* The main entry point in this file. Called from net/co

Re: [PATCH] ethtool: reduce stack usage with clang

2019-03-07 Thread Michal Kubecek
On Thu, Mar 07, 2019 at 10:33:35AM +0100, Arnd Bergmann wrote: > clang inlines the dev_ethtool() more aggressively than gcc does, leading > to a larger amount of used stack space: > > net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function > 'dev_ethtool' [-Werror,-Wframe-la

[PATCH] ethtool: reduce stack usage with clang

2019-03-07 Thread Arnd Bergmann
clang inlines the dev_ethtool() more aggressively than gcc does, leading to a larger amount of used stack space: net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function 'dev_ethtool' [-Werror,-Wframe-larger-than=] Marking the sub-functions that require the most stack space