Re: [PATCH] ewrk3: silence GCC warning

2012-11-26 Thread Paul Bolle
On Sun, 2012-11-25 at 11:45 +0100, richard -rw- weinberger wrote: > > While we're touching this code also drop an outdated comment, that > > should have been dropped with the patch named "MODULE_PARM conversions" > > from early 2005. > > Please send this change as an additional patch. Sure. Altho

Re: [PATCH] ewrk3: silence GCC warning

2012-11-25 Thread richard -rw- weinberger
On Sat, Nov 24, 2012 at 1:12 PM, Paul Bolle wrote: > Building ewrk3.o triggers this GCC warning: > drivers/net/ethernet/dec/ewrk3.c: In function '__check_irq': > drivers/net/ethernet/dec/ewrk3.c:1915:1: warning: return from > incompatible pointer type [enabled by default] > > This can be

[PATCH] ewrk3: silence GCC warning

2012-11-24 Thread Paul Bolle
Building ewrk3.o triggers this GCC warning: drivers/net/ethernet/dec/ewrk3.c: In function '__check_irq': drivers/net/ethernet/dec/ewrk3.c:1915:1: warning: return from incompatible pointer type [enabled by default] This can be trivially fixed by changing the 'irq' parameter from int to byt