Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Mariusz Kozlowski
> ->s_group_desc have to be zero filled because if sb_read() failed > we jump to following error path. > failed_mount2: > for (i = 0; i < db_count; i++) > brelse(sbi->s_group_desc[i]);<< Bad things may happen here > > Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]> > --- >

Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Aneesh Kumar K.V
Dmitry Monakhov wrote: ->s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i < db_count; i++) brelse(sbi->s_group_desc[i]);<< Bad things may happen here But the db_count is updated in the

Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Dmitry Monakhov
On 13:09 Mon 13 Aug , Dmitry Monakhov wrote: > ->s_group_desc have to be zero filled because if sb_read() failed > we jump to following error path. > failed_mount2: > for (i = 0; i < db_count; i++) > brelse(sbi->s_group_desc[i]);<< Bad things may happen here OOPs i'm sorry.

[PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Dmitry Monakhov
->s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i < db_count; i++) brelse(sbi->s_group_desc[i]);<< Bad things may happen here Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]> ---

Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Dmitry Monakhov
On 13:09 Mon 13 Aug , Dmitry Monakhov wrote: -s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i db_count; i++) brelse(sbi-s_group_desc[i]); Bad things may happen here OOPs i'm sorry. I've lost

[PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Dmitry Monakhov
-s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i db_count; i++) brelse(sbi-s_group_desc[i]); Bad things may happen here Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED] --- fs/ext3/super.c |

Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Aneesh Kumar K.V
Dmitry Monakhov wrote: -s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i db_count; i++) brelse(sbi-s_group_desc[i]); Bad things may happen here But the db_count is updated in the failure

Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Mariusz Kozlowski
-s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i db_count; i++) brelse(sbi-s_group_desc[i]); Bad things may happen here Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED] --- fs/ext3/super.c