Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Dilger wrote: > On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: >> Currently, if a corrupted directory entry with rec_len=0 is encountered, >> we still trust that the data is valid. This can cause an infinite loop >> in

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Eric Sandeen
Andreas Dilger wrote: > On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: >> Currently, if a corrupted directory entry with rec_len=0 is encountered, >> we still trust that the data is valid. This can cause an infinite loop >> in htree_dirblock_to_tree() since the iteration loop will never make

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Andreas Dilger
On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: > Currently, if a corrupted directory entry with rec_len=0 is encountered, > we still trust that the data is valid. This can cause an infinite loop > in htree_dirblock_to_tree() since the iteration loop will never make any > progress.

[PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Jeff Mahoney
This patch adds integrity checking to two htree paths that are missing it. Currently, if a corrupted directory entry with rec_len=0 is encountered, we still trust that the data is valid. This can cause an infinite loop in htree_dirblock_to_tree() since the iteration loop will never make any

[PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Jeff Mahoney
This patch adds integrity checking to two htree paths that are missing it. Currently, if a corrupted directory entry with rec_len=0 is encountered, we still trust that the data is valid. This can cause an infinite loop in htree_dirblock_to_tree() since the iteration loop will never make any

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Andreas Dilger
On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: Currently, if a corrupted directory entry with rec_len=0 is encountered, we still trust that the data is valid. This can cause an infinite loop in htree_dirblock_to_tree() since the iteration loop will never make any progress. Actually, I

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Eric Sandeen
Andreas Dilger wrote: On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: Currently, if a corrupted directory entry with rec_len=0 is encountered, we still trust that the data is valid. This can cause an infinite loop in htree_dirblock_to_tree() since the iteration loop will never make any

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Dilger wrote: On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: Currently, if a corrupted directory entry with rec_len=0 is encountered, we still trust that the data is valid. This can cause an infinite loop in htree_dirblock_to_tree()