Re: [PATCH] ext4: Add statx support

2017-04-12 Thread Jan Kara
On Sun 19-03-17 12:12:37, Jan Kara wrote: > On Fri 17-03-17 14:19:22, Andreas Dilger wrote: > > On Mar 16, 2017, at 11:47 PM, Eric Biggers wrote: > > > On Thu, Mar 16, 2017 at 11:35:33AM +, David Howells wrote: > > >> + > > >> +ext4_get_inode_flags(ei); > > >> +flags = ei->i_fl

Re: [PATCH] ext4: Add statx support

2017-03-31 Thread Andreas Dilger
On Mar 31, 2017, at 9:28 AM, David Howells wrote: > > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: > > (1) The inode creation time (i_crtime) as stx_btime, setting STATX_BTIME. > > (2) Certain FS_xxx_FL flags are mapped to stx_attribute flags. > > T

[PATCH] ext4: Add statx support

2017-03-31 Thread David Howells
Return enhanced file attributes from the Ext4 filesystem. This includes the following: (1) The inode creation time (i_crtime) as stx_btime, setting STATX_BTIME. (2) Certain FS_xxx_FL flags are mapped to stx_attribute flags. This requires that all ext4 inodes have a getattr call, not just some

Re: [PATCH] ext4: Add statx support

2017-03-31 Thread David Howells
Eric Biggers wrote: > Ultimately this needs to be addressed in ext4 more fully, but how about for > ->getattr() just skipping the call to ext4_get_inode_flags() and instead > populating the generic attributes like STATX_ATTR_APPEND and > STATX_ATTR_IMMUTABLE from the generic inode flags, rather t

Re: [PATCH] ext4: Add statx support

2017-03-20 Thread Christoph Hellwig
On Thu, Mar 16, 2017 at 11:35:33AM +, David Howells wrote: > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: Just as the comment to a similar patch from Darrick for XFS: Please add test cases that verify this information. Especially in the light of t

Re: [PATCH] ext4: Add statx support

2017-03-19 Thread Jan Kara
On Fri 17-03-17 14:19:22, Andreas Dilger wrote: > On Mar 16, 2017, at 11:47 PM, Eric Biggers wrote: > > On Thu, Mar 16, 2017 at 11:35:33AM +, David Howells wrote: > >> + > >> + ext4_get_inode_flags(ei); > >> + flags = ei->i_flags & EXT4_FL_USER_VISIBLE; > >> + if (flags & EXT4_APPEND_FL) >

Re: [PATCH] ext4: Add statx support

2017-03-17 Thread Andreas Dilger
On Mar 16, 2017, at 11:47 PM, Eric Biggers wrote: > On Thu, Mar 16, 2017 at 11:35:33AM +, David Howells wrote: >> + >> +ext4_get_inode_flags(ei); >> +flags = ei->i_flags & EXT4_FL_USER_VISIBLE; >> +if (flags & EXT4_APPEND_FL) >> +stat->attributes |= STATX_ATTR_APPEND; >

Re: [PATCH] ext4: Add statx support

2017-03-16 Thread Eric Biggers
Hi David, On Thu, Mar 16, 2017 at 11:35:33AM +, David Howells wrote: > + > + ext4_get_inode_flags(ei); > + flags = ei->i_flags & EXT4_FL_USER_VISIBLE; > + if (flags & EXT4_APPEND_FL) > + stat->attributes |= STATX_ATTR_APPEND; > + if (flags & EXT4_COMPR_FL) > +

Re: [PATCH] ext4: Add statx support

2017-03-16 Thread Andreas Dilger
On Mar 16, 2017, at 5:35 AM, David Howells wrote: > > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: > > (1) The inode creation time (i_crtime) as stx_btime, setting STATX_BTIME. > > (2) Certain FS_xxx_FL flags are mapped to stx_attribute flags. > > T

[PATCH] ext4: Add statx support

2017-03-16 Thread David Howells
Return enhanced file attributes from the Ext4 filesystem. This includes the following: (1) The inode creation time (i_crtime) as stx_btime, setting STATX_BTIME. (2) Certain FS_xxx_FL flags are mapped to stx_attribute flags. This requires that all ext4 inodes have a getattr call, not just some