Re: [PATCH] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-01 Thread Andreas Dilger
On Apr 1, 2021, at 1:22 AM, Ye Bin wrote: > > As read_mmp_block return 1 when failed, so just pass retval to > save_error_info. Thank you for submitting this patch, but it should not be accepted. The commit message is confusing, since the code being changed relates to retval from write_mmp_bloc

[PATCH] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-01 Thread Ye Bin
As read_mmp_block return 1 when failed, so just pass retval to save_error_info. Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()") Reported-by: Liu Zhi Qiang Signed-off-by: Ye Bin --- fs/ext4/mmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(