Re: [PATCH] ext4: address a benign compiler warning

2014-02-17 Thread Theodore Ts'o
On Wed, Feb 12, 2014 at 11:12:04PM -0500, Patrick Palka wrote: > When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as a > no_printk() statement instead of an empty statement in order to suppress > the following compiler warning: > > fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’:

[PATCH] ext4: address a benign compiler warning

2014-02-12 Thread Patrick Palka
When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as a no_printk() statement instead of an empty statement in order to suppress the following compiler warning: fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’: fs/ext4/mballoc.c:2659:47: warning: suggest braces around empty body in

Re: [PATCH] ext4: address a benign compiler warning

2014-02-12 Thread Patrick Palka
On Wed, Feb 12, 2014 at 9:59 PM, Joe Perches wrote: > On Wed, 2014-02-12 at 21:13 -0500, Patrick Palka wrote: >> When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as an >> empty do-while statement so as to suppress the following compiler >> warning: > > Hello Patrick. > >> fs/ext4/mba

Re: [PATCH] ext4: address a benign compiler warning

2014-02-12 Thread Joe Perches
On Wed, 2014-02-12 at 21:13 -0500, Patrick Palka wrote: > When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as an > empty do-while statement so as to suppress the following compiler > warning: Hello Patrick. > fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’: > fs/ext4/mballoc.c:2

[PATCH] ext4: address a benign compiler warning

2014-02-12 Thread Patrick Palka
When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as an empty do-while statement so as to suppress the following compiler warning: fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’: fs/ext4/mballoc.c:2659:47: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-b