Re: [PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2014-02-21 Thread Jan Kara
On Thu 20-02-14 19:21:07, Ted Tso wrote: > On Fri, Sep 27, 2013 at 06:05:17PM +0200, Jan Kara wrote: > > On Fri 27-09-13 19:54:03, Maxim Patlasov wrote: > > > While handling punch-hole fallocate, it's useless to truncate page cache > > > before removing the range from extent tree (or block map in

Re: [PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2014-02-21 Thread Jan Kara
On Thu 20-02-14 19:21:07, Ted Tso wrote: On Fri, Sep 27, 2013 at 06:05:17PM +0200, Jan Kara wrote: On Fri 27-09-13 19:54:03, Maxim Patlasov wrote: While handling punch-hole fallocate, it's useless to truncate page cache before removing the range from extent tree (or block map in indirect

Re: [PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2014-02-20 Thread Theodore Ts'o
On Fri, Sep 27, 2013 at 06:05:17PM +0200, Jan Kara wrote: > On Fri 27-09-13 19:54:03, Maxim Patlasov wrote: > > While handling punch-hole fallocate, it's useless to truncate page cache > > before removing the range from extent tree (or block map in indirect case) > > because page cache can be

Re: [PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2014-02-20 Thread Theodore Ts'o
On Fri, Sep 27, 2013 at 06:05:17PM +0200, Jan Kara wrote: On Fri 27-09-13 19:54:03, Maxim Patlasov wrote: While handling punch-hole fallocate, it's useless to truncate page cache before removing the range from extent tree (or block map in indirect case) because page cache can be

Re: [PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2013-09-27 Thread Jan Kara
On Fri 27-09-13 19:54:03, Maxim Patlasov wrote: > While handling punch-hole fallocate, it's useless to truncate page cache > before removing the range from extent tree (or block map in indirect case) > because page cache can be re-populated (by read-ahead or read(2) or mmap-ed > read) immediately

[PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2013-09-27 Thread Maxim Patlasov
While handling punch-hole fallocate, it's useless to truncate page cache before removing the range from extent tree (or block map in indirect case) because page cache can be re-populated (by read-ahead or read(2) or mmap-ed read) immediately after truncating page cache, but before updating extent

[PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2013-09-27 Thread Maxim Patlasov
While handling punch-hole fallocate, it's useless to truncate page cache before removing the range from extent tree (or block map in indirect case) because page cache can be re-populated (by read-ahead or read(2) or mmap-ed read) immediately after truncating page cache, but before updating extent

Re: [PATCH] ext4: avoid exposure of stale data in ext4_punch_hole() -v2

2013-09-27 Thread Jan Kara
On Fri 27-09-13 19:54:03, Maxim Patlasov wrote: While handling punch-hole fallocate, it's useless to truncate page cache before removing the range from extent tree (or block map in indirect case) because page cache can be re-populated (by read-ahead or read(2) or mmap-ed read) immediately