Re: [PATCH] ext4: fix transposition typo in format string

2015-04-02 Thread Theodore Ts'o
On Fri, Feb 20, 2015 at 03:11:35PM +0100, Rasmus Villemoes wrote: > According to C99, %*.s means the same as %*.0s, in other words, print > as many spaces as the field width argument says and effectively ignore > the string argument. That is certainly not what was meant here. The > kernel's printf

Re: [PATCH] ext4: fix transposition typo in format string

2015-03-02 Thread Rasmus Villemoes
Ping... (maybe I should have used a more dramatic subject - I do think this is a real bug, but if not, I'd still like to get an explicit NAK.) On Fri, Feb 20 2015, Rasmus Villemoes wrote: > According to C99, %*.s means the same as %*.0s, in other words, print > as many spaces as the field width

[PATCH] ext4: fix transposition typo in format string

2015-02-20 Thread Rasmus Villemoes
According to C99, %*.s means the same as %*.0s, in other words, print as many spaces as the field width argument says and effectively ignore the string argument. That is certainly not what was meant here. The kernel's printf implementation, however, treats it as if the . was not there, i.e. as %*s.