Re: [PATCH] ext4: make __ext4_get_inode_loc plug

2019-06-19 Thread Zhangjs Jinshui
> 在 2019年6月19日，19:08，Jan Kara 写道： > > On Mon 17-06-19 23:57:12, jinshui zhang wrote: >> From: zhangjs >> >> If the task is unplugged when called, the inode_readahead_blks may not be >> merged, >> these will cause small pieces of io, It should be plugged. >> >> Signed-off-by: zhangjs > >

Re: [PATCH] ext4: make __ext4_get_inode_loc plug

2019-06-19 Thread Theodore Ts'o
On Mon, Jun 17, 2019 at 11:57:12PM +0800, jinshui zhang wrote: > From: zhangjs > > If the task is unplugged when called, the inode_readahead_blks may not be > merged, > these will cause small pieces of io, It should be plugged. > > Signed-off-by: zhangjs Thanks, applied. I cleaned up the

Re: [PATCH] ext4: make __ext4_get_inode_loc plug

2019-06-19 Thread Jan Kara
On Wed 19-06-19 19:34:00, Zhangjs Jinshui wrote: > You can blktrace > > 8,80 31 11 0.296373038 2885275 Q RA 8279571464 + 8 [] > 8,80 31 12 0.296374017 2885275 G RA 8279571464 + 8 [] > 8,80 31 13 0.296375468 2885275 I RA 8279571464 + 8 [] >

Re: [PATCH] ext4: make __ext4_get_inode_loc plug

2019-06-19 Thread Jan Kara
On Mon 17-06-19 23:57:12, jinshui zhang wrote: > From: zhangjs > > If the task is unplugged when called, the inode_readahead_blks may not be > merged, > these will cause small pieces of io, It should be plugged. > > Signed-off-by: zhangjs Out of curiosity, on which path do you see

[PATCH] ext4: make __ext4_get_inode_loc plug

2019-06-17 Thread jinshui zhang
From: zhangjs If the task is unplugged when called, the inode_readahead_blks may not be merged, these will cause small pieces of io, It should be plugged. Signed-off-by: zhangjs --- fs/ext4/inode.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c

Re: [PATCH] ext4: make __ext4_get_inode_loc plug

2019-06-17 Thread Theodore Ts'o
On Mon, Jun 17, 2019 at 03:11:21PM +0800, Zhangjs Jinshui wrote: > If the task is unplugged when called, the inode_readahead_blks may not be > merged, > these will cause small pieces of io, It should be plugged. > > Signed-off-by: zhangjs This patch is white space damaged. Please see: