Re: [PATCH] ext4: remove unnecessary gotos in ext4_xattr_set_entry

2019-06-01 Thread Theodore Ts'o
On Fri, May 31, 2019 at 03:46:54PM -0600, Andreas Dilger wrote: > On May 31, 2019, at 6:10 AM, Pavel Tikhomirov > wrote: > > > > In the "out" label we only iput old/new_ea_inode-s, in all these places > > these variables are always NULL so there is no point in goto to "out". > > > > Signed-off-

Re: [PATCH] ext4: remove unnecessary gotos in ext4_xattr_set_entry

2019-05-31 Thread Andreas Dilger
On May 31, 2019, at 6:10 AM, Pavel Tikhomirov wrote: > > In the "out" label we only iput old/new_ea_inode-s, in all these places > these variables are always NULL so there is no point in goto to "out". > > Signed-off-by: Pavel Tikhomirov I'm not a fan of changes like this, since it adds potent

[PATCH] ext4: remove unnecessary gotos in ext4_xattr_set_entry

2019-05-31 Thread Pavel Tikhomirov
In the "out" label we only iput old/new_ea_inode-s, in all these places these variables are always NULL so there is no point in goto to "out". Signed-off-by: Pavel Tikhomirov --- fs/ext4/xattr.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/ext4/xattr.c b/fs/ext