Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-29 Thread Stephen Boyd
On 29 June 2016 at 17:35, Chanwoo Choi wrote: > On 2016년 06월 30일 03:48, Stephen Boyd wrote: >> Quoting Chanwoo Choi (2016-06-28 23:25:57) >>> On 2016년 06월 29일 06:59, Stephen Boyd wrote: Quoting Chanwoo Choi (2016-06-28 05:06:48) > 2016-06-28 4:11 GMT+09:00 Stephen Boyd : >> Quoting Ch

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-29 Thread Chanwoo Choi
On 2016년 06월 30일 03:48, Stephen Boyd wrote: > Quoting Chanwoo Choi (2016-06-28 23:25:57) >> On 2016년 06월 29일 06:59, Stephen Boyd wrote: >>> Quoting Chanwoo Choi (2016-06-28 05:06:48) 2016-06-28 4:11 GMT+09:00 Stephen Boyd : > Quoting Chanwoo Choi (2016-06-26 04:20:43) >> 2016-06-26 14:

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-29 Thread Stephen Boyd
Quoting Roger Quadros (2016-06-28 23:10:57) > On 29/06/16 01:01, Stephen Boyd wrote: > > Quoting Roger Quadros (2016-06-28 02:13:57) > >> On 28/06/16 11:47, Stephen Boyd wrote: > >>> > >>> Sorry I must have confused you. There are two modules in the PMIC that > >>> are doing detection here. The cha

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-29 Thread Stephen Boyd
Quoting Chanwoo Choi (2016-06-28 23:25:57) > On 2016년 06월 29일 06:59, Stephen Boyd wrote: > > Quoting Chanwoo Choi (2016-06-28 05:06:48) > >> 2016-06-28 4:11 GMT+09:00 Stephen Boyd : > >>> Quoting Chanwoo Choi (2016-06-26 04:20:43) > 2016-06-26 14:56 GMT+09:00 Stephen Boyd : > > +PROPERTIES

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Chanwoo Choi
On 2016년 06월 29일 06:59, Stephen Boyd wrote: > Quoting Chanwoo Choi (2016-06-28 05:06:48) >> 2016-06-28 4:11 GMT+09:00 Stephen Boyd : >>> Quoting Chanwoo Choi (2016-06-26 04:20:43) 2016-06-26 14:56 GMT+09:00 Stephen Boyd : > +PROPERTIES > + > +- compatible: > +Usage: require

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Roger Quadros
On 29/06/16 01:01, Stephen Boyd wrote: > Quoting Roger Quadros (2016-06-28 02:13:57) >> On 28/06/16 11:47, Stephen Boyd wrote: >>> >>> Sorry I must have confused you. There are two modules in the PMIC that >>> are doing detection here. The charger module is detecting the VBUS event >>> and this mis

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Stephen Boyd
Quoting Roger Quadros (2016-06-28 02:13:57) > On 28/06/16 11:47, Stephen Boyd wrote: > > > > Sorry I must have confused you. There are two modules in the PMIC that > > are doing detection here. The charger module is detecting the VBUS event > > and this misc module is detecting the ID pin. I'm not

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Chanwoo Choi
2016-06-28 4:11 GMT+09:00 Stephen Boyd : > Quoting Chanwoo Choi (2016-06-26 04:20:43) >> 2016-06-26 14:56 GMT+09:00 Stephen Boyd : >> > +PROPERTIES >> > + >> > +- compatible: >> > +Usage: required >> > +Value type: >> > +Definition: Should contain "qcom,pm8941-misc"; >> > + >> > +- reg

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Roger Quadros
On 28/06/16 11:47, Stephen Boyd wrote: > Quoting Roger Quadros (2016-06-27 23:36:26) >> On 27/06/16 22:30, Stephen Boyd wrote: >>> >>> The VBUS notification is done through another piece of hardware. In this >>> case it's done by the charger module. I've sent a patch for that[1]. >> >> Isn't it bet

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Stephen Boyd
Quoting Roger Quadros (2016-06-27 23:36:26) > On 27/06/16 22:30, Stephen Boyd wrote: > > > > The VBUS notification is done through another piece of hardware. In this > > case it's done by the charger module. I've sent a patch for that[1]. > > Isn't it better if ID event is handled as well in that

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-27 Thread Roger Quadros
On 27/06/16 22:30, Stephen Boyd wrote: > Quoting Roger Quadros (2016-06-27 00:39:51) >> Hi Stephen, >> >> On 26/06/16 08:56, Stephen Boyd wrote: >>> Some Qualcomm PMICs have a misc device that performs USB id pin >>> detection via an interrupt. When the interrupt triggers, we >>> should read the in

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-27 Thread Stephen Boyd
Quoting Roger Quadros (2016-06-27 00:39:51) > Hi Stephen, > > On 26/06/16 08:56, Stephen Boyd wrote: > > Some Qualcomm PMICs have a misc device that performs USB id pin > > detection via an interrupt. When the interrupt triggers, we > > should read the interrupt line to see if it has gone high or

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-27 Thread Roger Quadros
Hi Stephen, On 26/06/16 08:56, Stephen Boyd wrote: > Some Qualcomm PMICs have a misc device that performs USB id pin > detection via an interrupt. When the interrupt triggers, we > should read the interrupt line to see if it has gone high or low. > If the interrupt is low then the ID pin is ground

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-26 Thread Chanwoo Choi
Hi, 2016-06-26 20:20 GMT+09:00 Chanwoo Choi : > Hi, > > This patch looks good to me. > But, there is some comment. > > 2016-06-26 14:56 GMT+09:00 Stephen Boyd : >> Some Qualcomm PMICs have a misc device that performs USB id pin >> detection via an interrupt. When the interrupt triggers, we >> shou

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-26 Thread Chanwoo Choi
Hi, This patch looks good to me. But, there is some comment. 2016-06-26 14:56 GMT+09:00 Stephen Boyd : > Some Qualcomm PMICs have a misc device that performs USB id pin > detection via an interrupt. When the interrupt triggers, we > should read the interrupt line to see if it has gone high or low

[PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-25 Thread Stephen Boyd
Some Qualcomm PMICs have a misc device that performs USB id pin detection via an interrupt. When the interrupt triggers, we should read the interrupt line to see if it has gone high or low. If the interrupt is low then the ID pin is grounded, and if the interrupt is high then the ID pin is being he