Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-10-01 Thread Chanwoo Choi
On 10/01/2013 05:22 PM, Charles Keepax wrote: > On Tue, Oct 01, 2013 at 08:04:09AM +0900, Chanwoo Choi wrote: >> On 09/30/2013 06:52 PM, Charles Keepax wrote: >>> On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote: No, extcon-arizona driver don't currently support DT to get platform

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-10-01 Thread Charles Keepax
On Tue, Oct 01, 2013 at 08:04:09AM +0900, Chanwoo Choi wrote: > On 09/30/2013 06:52 PM, Charles Keepax wrote: > > On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote: > >> No, extcon-arizona driver don't currently support DT to get platform data. > >> I cannot find some dt function to pars

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-30 Thread Mark Brown
On Tue, Oct 01, 2013 at 08:14:39AM +0900, Chanwoo Choi wrote: > Additionally,I have a question. > As I mentioned, extcon-arizon driver don't get pdata from dt parsing. > I think extcon-arizona haven't operated without pdata. It should work fine on Wolfson reference systems and anything cloned fro

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-30 Thread Mark Brown
On Tue, Oct 01, 2013 at 08:04:09AM +0900, Chanwoo Choi wrote: > On 09/30/2013 06:52 PM, Charles Keepax wrote: > > I would also be happy to implement this as a NULL check on the > > pdata when we use it if that is preferable? But since we have the > > cached pdata seems we might as well use it. >

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-30 Thread Chanwoo Choi
On 10/01/2013 08:04 AM, Chanwoo Choi wrote: > On 09/30/2013 06:52 PM, Charles Keepax wrote: >> On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote: >>> No, extcon-arizona driver don't currently support DT to get platform data. >>> I cannot find some dt function to parse data from dts file.

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-30 Thread Chanwoo Choi
On 09/30/2013 06:52 PM, Charles Keepax wrote: > On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote: >> No, extcon-arizona driver don't currently support DT to get platform data. >> I cannot find some dt function to parse data from dts file. >> You have to implement extcon-arizona driver b

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-30 Thread Charles Keepax
On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote: > No, extcon-arizona driver don't currently support DT to get platform data. > I cannot find some dt function to parse data from dts file. > You have to implement extcon-arizona driver by using DT binding style > to get platform data. I

Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-29 Thread Chanwoo Choi
On 09/28/2013 11:34 PM, Charles Keepax wrote: > In the case of a device tree system there will be no pdata attached to > the device, causing us to deference a NULL pointer. Better to take the > pdata from the Arizona structure as this will always exist and we know > will have been populated since i

[PATCH] extcon: arizona: Get pdata from arizona structure not device

2013-09-28 Thread Charles Keepax
In the case of a device tree system there will be no pdata attached to the device, causing us to deference a NULL pointer. Better to take the pdata from the Arizona structure as this will always exist and we know will have been populated since it is populated by the MFD device which binds in the ex