Re: [PATCH] extcon: arizona: Implement button detection support

2012-08-04 Thread Mark Brown
On Sat, Aug 04, 2012 at 12:07:34PM +0530, anish kumar wrote: > According to my discussion with Mr. Myunjoo Ham.He said that single > driver should not be used for communicating with both extcon and input > subsystem and that is the reason he suggested that I split the samsung > jack driver into

Re: [PATCH] extcon: arizona: Implement button detection support

2012-08-04 Thread anish kumar
On Wed, 2012-07-25 at 15:09 +0900, Chanwoo Choi wrote: > Hi Mark, > > On 07/21/2012 01:07 AM, Mark Brown wrote: > > > As well as identifying accessories the accessory detection hardware on > > Arizona class devices can also detect a number of buttons which we should > > report via the input API.

Re: [PATCH] extcon: arizona: Implement button detection support

2012-08-04 Thread anish kumar
On Wed, 2012-07-25 at 15:09 +0900, Chanwoo Choi wrote: Hi Mark, On 07/21/2012 01:07 AM, Mark Brown wrote: As well as identifying accessories the accessory detection hardware on Arizona class devices can also detect a number of buttons which we should report via the input API.

Re: [PATCH] extcon: arizona: Implement button detection support

2012-08-04 Thread Mark Brown
On Sat, Aug 04, 2012 at 12:07:34PM +0530, anish kumar wrote: According to my discussion with Mr. Myunjoo Ham.He said that single driver should not be used for communicating with both extcon and input subsystem and that is the reason he suggested that I split the samsung jack driver into two

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-27 Thread Chanwoo Choi
On 07/26/2012 05:11 PM, Mark Brown wrote: > On Thu, Jul 26, 2012 at 09:10:08AM +0900, Chanwoo Choi wrote: > >> If user press BTN_0 and BTN_1 at the same time and then user only >> released BTN_0 but BTN_1 is still pressed, is it right that report >> released event to all of buttons? I think that

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-27 Thread Chanwoo Choi
On 07/26/2012 05:11 PM, Mark Brown wrote: On Thu, Jul 26, 2012 at 09:10:08AM +0900, Chanwoo Choi wrote: If user press BTN_0 and BTN_1 at the same time and then user only released BTN_0 but BTN_1 is still pressed, is it right that report released event to all of buttons? I think that

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-26 Thread Mark Brown
On Thu, Jul 26, 2012 at 09:10:08AM +0900, Chanwoo Choi wrote: > If user press BTN_0 and BTN_1 at the same time and then user only > released BTN_0 but BTN_1 is still pressed, is it right that report > released event to all of buttons? I think that different event between > BTN_0 and BTN_1. That

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-26 Thread Mark Brown
On Thu, Jul 26, 2012 at 09:10:08AM +0900, Chanwoo Choi wrote: If user press BTN_0 and BTN_1 at the same time and then user only released BTN_0 but BTN_1 is still pressed, is it right that report released event to all of buttons? I think that different event between BTN_0 and BTN_1. That

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Chanwoo Choi
On 07/25/2012 08:11 PM, Mark Brown wrote: >> Why do you should report released event to all of buttons? I think that >> you should only >> report released event to previous pressed button. If user press two >> button on the headset >> at the same time and then user release only one button with

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Mark Brown
On Wed, Jul 25, 2012 at 03:09:56PM +0900, Chanwoo Choi wrote: > On 07/21/2012 01:07 AM, Mark Brown wrote: Please delete irrelevant context from your replies, it makes it much easier to find what you're saying. > Why do you should report released event to all of buttons? I think that > you should

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Chanwoo Choi
Hi Mark, On 07/21/2012 01:07 AM, Mark Brown wrote: > As well as identifying accessories the accessory detection hardware on > Arizona class devices can also detect a number of buttons which we should > report via the input API. > > Signed-off-by: Mark Brown > --- >

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Chanwoo Choi
On 07/25/2012 08:11 PM, Mark Brown wrote: Why do you should report released event to all of buttons? I think that you should only report released event to previous pressed button. If user press two button on the headset at the same time and then user release only one button with pressed

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Chanwoo Choi
Hi Mark, On 07/21/2012 01:07 AM, Mark Brown wrote: As well as identifying accessories the accessory detection hardware on Arizona class devices can also detect a number of buttons which we should report via the input API. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com ---

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Mark Brown
On Wed, Jul 25, 2012 at 03:09:56PM +0900, Chanwoo Choi wrote: On 07/21/2012 01:07 AM, Mark Brown wrote: Please delete irrelevant context from your replies, it makes it much easier to find what you're saying. Why do you should report released event to all of buttons? I think that you should

[PATCH] extcon: arizona: Implement button detection support

2012-07-20 Thread Mark Brown
As well as identifying accessories the accessory detection hardware on Arizona class devices can also detect a number of buttons which we should report via the input API. Signed-off-by: Mark Brown --- drivers/extcon/extcon-arizona.c | 72 +++ 1 file

[PATCH] extcon: arizona: Implement button detection support

2012-07-20 Thread Mark Brown
As well as identifying accessories the accessory detection hardware on Arizona class devices can also detect a number of buttons which we should report via the input API. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 72