Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-22 Thread Greg KH
On Fri, Oct 19, 2012 at 02:12:06AM +0900, anish kumar wrote: > From: anish kumar > > We don't need a release call in this file as we are doing > everything needed in unregister call and we don't have any > more pointer to free up. > > Signed-off-by: anish kumar > --- > drivers/extcon/extcon-cl

Re: [PATCH] extcon: driver model release call not needed

2012-10-21 Thread Chanwoo Choi
On 10/21/2012 01:46 PM, anish kumar wrote: > From: anish kumar > > There was a case where free and list_del can be called twice > on the same pointer.So fixed it by re-arranging the code and > removing a function which was not needed. > > Signed-off-by: anish kumar > --- > drivers/extcon/extco

Re: [PATCH] extcon: driver model release call not needed

2012-10-20 Thread anish kumar
Hi Choi, This is based on http://git.infradead.org/users/kmpark/linux-samsung this branch. anish On Sun, 2012-10-21 at 13:46 +0900, anish kumar wrote: > From: anish kumar > > There was a case where free and list_del can be called twice > on the same pointer.So fixed it by re-arranging the code a

[PATCH] extcon: driver model release call not needed

2012-10-20 Thread anish kumar
From: anish kumar There was a case where free and list_del can be called twice on the same pointer.So fixed it by re-arranging the code and removing a function which was not needed. Signed-off-by: anish kumar --- drivers/extcon/extcon-class.c | 71 ++--- 1

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread Chanwoo Choi
On 10/20/2012 12:33 PM, anish kumar wrote: [] > How about below? I agree, but there were some minor issues, [] > > static const char *muex_name = "mutually_exclusive"; > @@ -813,7 +779,32 @@ EXPORT_SYMBOL_GPL(extcon_dev_register); > */ > void extcon_dev_unregister(struct extcon_dev

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread anish kumar
On Sat, 2012-10-20 at 11:37 +0900, Chanwoo Choi wrote: > On 10/20/2012 11:30 AM, anish kumar wrote: > > On Sat, 2012-10-20 at 10:57 +0900, Chanwoo Choi wrote: > >> On 10/19/2012 02:12 AM, anish kumar wrote: > >>> From: anish kumar > >>> > >>> We don't need a release call in this file as we are doi

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread Chanwoo Choi
On 10/20/2012 11:30 AM, anish kumar wrote: > On Sat, 2012-10-20 at 10:57 +0900, Chanwoo Choi wrote: >> On 10/19/2012 02:12 AM, anish kumar wrote: >>> From: anish kumar >>> >>> We don't need a release call in this file as we are doing >>> everything needed in unregister call and we don't have any >

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread anish kumar
On Sat, 2012-10-20 at 10:57 +0900, Chanwoo Choi wrote: > On 10/19/2012 02:12 AM, anish kumar wrote: > > From: anish kumar > > > > We don't need a release call in this file as we are doing > > everything needed in unregister call and we don't have any > > more pointer to free up. > > > > Signed-o

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread Chanwoo Choi
On 10/19/2012 02:12 AM, anish kumar wrote: > From: anish kumar > > We don't need a release call in this file as we are doing > everything needed in unregister call and we don't have any > more pointer to free up. > > Signed-off-by: anish kumar > --- > drivers/extcon/extcon-class.c |4 +---

[PATCH] [PATCH] extcon: driver model release call not needed

2012-10-18 Thread anish kumar
From: anish kumar We don't need a release call in this file as we are doing everything needed in unregister call and we don't have any more pointer to free up. Signed-off-by: anish kumar --- drivers/extcon/extcon-class.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git