Re: [PATCH] extcon: fix a missing check of regmap_read

2019-03-20 Thread Chanwoo Choi
Hi, You better to edit the patch title as following in order to sustain the title format for extcon: extcon: fix a missing check of regmap_read -> extcon: axp288: Fix a missing check of regmap_read On 19. 3. 20. 오후 4:35, Kangjie Lu wrote: > When regmap_read fails, it doesn't make sense to use

[PATCH] extcon: fix a missing check of regmap_read

2019-03-20 Thread Kangjie Lu
When regmap_read fails, it doesn't make sense to use the read value "val" because it can be uninitialized. The fix returns if regmap_read fails. Signed-off-by: Kangjie Lu --- drivers/extcon/extcon-axp288.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/extcon/extcon-axp288.c

Re: [PATCH] extcon: fix a missing check of regmap_read

2019-03-18 Thread Chanwoo Choi
Hi, On 19. 3. 19. 오전 1:41, Kangjie Lu wrote: > When regmap_read fails, it doesn't make sense to use the read > value "val" because it can be uninitialized. > > The fix returns if regmap_read fails. > > Signed-off-by: Kangjie Lu > --- > drivers/extcon/extcon-axp288.c | 4 > 1 file

Re: [PATCH] extcon: fix a missing check of regmap_read

2019-03-18 Thread Hans de Goede
Hi, On 18-03-19 17:41, Kangjie Lu wrote: When regmap_read fails, it doesn't make sense to use the read value "val" because it can be uninitialized. The fix returns if regmap_read fails. Signed-off-by: Kangjie Lu --- drivers/extcon/extcon-axp288.c | 4 1 file changed, 4 insertions(+)

[PATCH] extcon: fix a missing check of regmap_read

2019-03-18 Thread Kangjie Lu
When regmap_read fails, it doesn't make sense to use the read value "val" because it can be uninitialized. The fix returns if regmap_read fails. Signed-off-by: Kangjie Lu --- drivers/extcon/extcon-axp288.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/extcon/extcon-axp288.c