Re: [f2fs-dev] [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-13 Thread Chao Yu
On 2017/10/13 19:20, Yunlong Song wrote: > Yep, both are OK, since I do not care it is foreground or background. Here it > just needs to do gc. But you only set need_gc as true for foreground GC case. Thanks, > > On 2017/10/13 19:09, Chao Yu wrote: >> On 2017/10/11 21:51, Yunlong Song wrote: >

Re: [f2fs-dev] [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-13 Thread Yunlong Song
Yep, both are OK, since I do not care it is foreground or background. Here it just needs to do gc. On 2017/10/13 19:09, Chao Yu wrote: On 2017/10/11 21:51, Yunlong Song wrote: This can help us to debug on some corner case. Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 6 +- 1 file ch

Re: [f2fs-dev] [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-13 Thread Chao Yu
On 2017/10/11 21:51, Yunlong Song wrote: > This can help us to debug on some corner case. > > Signed-off-by: Yunlong Song > --- > fs/f2fs/gc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 197ebf4..960503e 100644 > --- a/fs/f2f

Re: [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-12 Thread Jaegeuk Kim
On 10/13, Yunlong Song wrote: > Hi, Jay, > I think it should not happen when need_gc == true but total_freed ==0, > so I add it as bug_on to let it panic at once. And even CHECK_FS is closed, > this can also printk WARNING message for notice. Ah, got it. Merged. :) Thanks, > > On 2017/10/13

Re: [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-12 Thread Yunlong Song
Hi, Jay, I think it should not happen when need_gc == true but total_freed ==0, so I add it as bug_on to let it panic at once. And even CHECK_FS is closed, this can also printk WARNING message for notice. On 2017/10/13 7:23, Jaegeuk Kim wrote: Hi Yunlong, On 10/11, Yunlong Song wrote: T

Re: [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-12 Thread Jaegeuk Kim
Hi Yunlong, On 10/11, Yunlong Song wrote: > This can help us to debug on some corner case. > > Signed-off-by: Yunlong Song > --- > fs/f2fs/gc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 197ebf4..960503e 100644 > --- a/fs/f

[PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-11 Thread Yunlong Song
This can help us to debug on some corner case. Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 197ebf4..960503e 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -986,6 +986,7 @@ int f2fs_gc(str