RE: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-10 Thread David Laight
From: Chao Yu > Sent: 10 November 2020 06:28 ... > Actually, I think the both results are the same, inode chksum doesn't match > inode > metadata, like current case that cluster chksum doesn't match cluster data, it > doesn't matter how it becomes mismatched. > > And also, in those inode corrupte

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-09 Thread Chao Yu
On 2020/11/10 12:23, Jaegeuk Kim wrote: On 11/10, Chao Yu wrote: On 2020/11/10 1:06, Jaegeuk Kim wrote: On 11/09, Chao Yu wrote: On 2020/11/7 5:12, Jaegeuk Kim wrote: On 11/03, Chao Yu wrote: On 2020/11/3 10:02, Chao Yu wrote: On 2020/11/3 0:31, Jaegeuk Kim wrote: On 11/02, Chao Yu wrote:

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-09 Thread Jaegeuk Kim
On 11/10, Chao Yu wrote: > On 2020/11/10 1:06, Jaegeuk Kim wrote: > > On 11/09, Chao Yu wrote: > > > On 2020/11/7 5:12, Jaegeuk Kim wrote: > > > > On 11/03, Chao Yu wrote: > > > > > On 2020/11/3 10:02, Chao Yu wrote: > > > > > > On 2020/11/3 0:31, Jaegeuk Kim wrote: > > > > > > > On 11/02, Chao Yu

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-09 Thread Chao Yu
On 2020/11/10 1:06, Jaegeuk Kim wrote: On 11/09, Chao Yu wrote: On 2020/11/7 5:12, Jaegeuk Kim wrote: On 11/03, Chao Yu wrote: On 2020/11/3 10:02, Chao Yu wrote: On 2020/11/3 0:31, Jaegeuk Kim wrote: On 11/02, Chao Yu wrote: This patch supports to store chksum value with compressed data, an

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-09 Thread Jaegeuk Kim
On 11/09, Chao Yu wrote: > On 2020/11/7 5:12, Jaegeuk Kim wrote: > > On 11/03, Chao Yu wrote: > > > On 2020/11/3 10:02, Chao Yu wrote: > > > > On 2020/11/3 0:31, Jaegeuk Kim wrote: > > > > > On 11/02, Chao Yu wrote: > > > > > > This patch supports to store chksum value with compressed > > > > > > d

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-08 Thread Chao Yu
On 2020/11/7 5:12, Jaegeuk Kim wrote: On 11/03, Chao Yu wrote: On 2020/11/3 10:02, Chao Yu wrote: On 2020/11/3 0:31, Jaegeuk Kim wrote: On 11/02, Chao Yu wrote: This patch supports to store chksum value with compressed data, and verify the integrality of compressed data while reading the data

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-06 Thread Jaegeuk Kim
On 11/03, Chao Yu wrote: > On 2020/11/3 10:02, Chao Yu wrote: > > On 2020/11/3 0:31, Jaegeuk Kim wrote: > > > On 11/02, Chao Yu wrote: > > > > This patch supports to store chksum value with compressed > > > > data, and verify the integrality of compressed data while > > > > reading the data. > > >

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-04 Thread Chao Yu
Jaegeuk, Any comments? On 2020/11/3 10:36, Chao Yu wrote: On 2020/11/3 10:02, Chao Yu wrote: On 2020/11/3 0:31, Jaegeuk Kim wrote: On 11/02, Chao Yu wrote: This patch supports to store chksum value with compressed data, and verify the integrality of compressed data while reading the data. T

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-03 Thread Chao Yu
On 2020/11/3 18:35, David Laight wrote: From: Chao Yu Sent: 03 November 2020 02:37 ... Do we need to change fsck.f2fs to recover this? However, we don't know which one is correct, compressed data or chksum value? if compressed data was corrupted, repairing chksum value doesn't help. Or how

RE: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-03 Thread David Laight
From: Chao Yu > Sent: 03 November 2020 02:37 ... > >> Do we need to change fsck.f2fs to recover this? > > However, we don't know which one is correct, compressed data or chksum value? > if compressed data was corrupted, repairing chksum value doesn't help. > > Or how about adding chksum values fo

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-02 Thread Chao Yu
On 2020/11/3 10:02, Chao Yu wrote: On 2020/11/3 0:31, Jaegeuk Kim wrote: On 11/02, Chao Yu wrote: This patch supports to store chksum value with compressed data, and verify the integrality of compressed data while reading the data. The feature can be enabled through specifying mount option 'co

Re: [PATCH] f2fs: compress: support chksum

2020-11-02 Thread Chao Yu
On 2020/11/3 0:31, Jaegeuk Kim wrote: On 11/02, Chao Yu wrote: This patch supports to store chksum value with compressed data, and verify the integrality of compressed data while reading the data. The feature can be enabled through specifying mount option 'compress_chksum'. Signed-off-by: Chao

Re: [PATCH] f2fs: compress: support chksum

2020-11-02 Thread kernel test robot
Hi Chao, I love your patch! Perhaps something to improve: [auto build test WARNING on f2fs/dev-test] [also build test WARNING on v5.10-rc2 next-20201102] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

Re: [PATCH] f2fs: compress: support chksum

2020-11-02 Thread Jaegeuk Kim
On 11/02, Chao Yu wrote: > This patch supports to store chksum value with compressed > data, and verify the integrality of compressed data while > reading the data. > > The feature can be enabled through specifying mount option > 'compress_chksum'. > > Signed-off-by: Chao Yu > --- > Documentati

[PATCH] f2fs: compress: support chksum

2020-11-02 Thread Chao Yu
This patch supports to store chksum value with compressed data, and verify the integrality of compressed data while reading the data. The feature can be enabled through specifying mount option 'compress_chksum'. Signed-off-by: Chao Yu --- Documentation/filesystems/f2fs.rst | 1 + fs/f2fs/compr