Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Chao Yu
On 2021/2/2 8:41, Daeho Jeong wrote: For less confusion, I am going to separate the "merge" option from Agreed. "checkpoint=". I am adding another "ckpt_merge" option. :) Not sure, maybe "checkpoint_merge" will be better? "ckpt_merge" looks more like a term only developer knew. Thanks,

Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Chao Yu
On 2021/2/1 21:11, Daeho Jeong wrote: Actually, I think we need to select one among them, disable, enable and merge. I realized my previous understanding about that was wrong. Actually, 1. chekcpoint=enable/disable decide whether we will allow checkpoint 2. checkpoint=merge or not decide how we

Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Daeho Jeong
For less confusion, I am going to separate the "merge" option from "checkpoint=". I am adding another "ckpt_merge" option. :) 2021년 2월 2일 (화) 오전 8:33, Daeho Jeong 님이 작성: > > The rightmost one is the final option. And checkpoint=merge means > checkpoint is enabled with a checkpoint thread. > > moun

Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Daeho Jeong
The rightmost one is the final option. And checkpoint=merge means checkpoint is enabled with a checkpoint thread. mount checkpoint=disable,checkpoint=merge => checkpoint=merge remount checkpoint=enable,checkpoint=merge => checkpoint=merge remount checkpoint=merge,checkpoint=disable => checkpoint=d

Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Jaegeuk Kim
On 02/01, Daeho Jeong wrote: > Actually, I think we need to select one among them, disable, enable > and merge. I realized my previous understanding about that was wrong. > In that case of "checkpoint=merge,checkpoint=enable", the last option > will override the ones before that. > This is how the

Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Daeho Jeong
Actually, I think we need to select one among them, disable, enable and merge. I realized my previous understanding about that was wrong. In that case of "checkpoint=merge,checkpoint=enable", the last option will override the ones before that. This is how the other mount options like fsync_mode, wh

Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination

2021-02-01 Thread Chao Yu
On 2021/2/1 8:06, Daeho Jeong wrote: From: Daeho Jeong As checkpoint=merge comes in, mount option setting related to checkpoint had been mixed up. Fixed it. Signed-off-by: Daeho Jeong --- fs/f2fs/super.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/f2f

[PATCH] f2fs: fix checkpoint mount option wrong combination

2021-01-31 Thread Daeho Jeong
From: Daeho Jeong As checkpoint=merge comes in, mount option setting related to checkpoint had been mixed up. Fixed it. Signed-off-by: Daeho Jeong --- fs/f2fs/super.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 56696f6