Re: [f2fs-dev] [PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

On 2020/6/1 17:20, Sahitya Tummala wrote: > Hi Chao, > > Can you please help review the diff given by Jaegeuk below? > If it looks good, I can post a v2. Oops, I missed to review that patch... > > Thanks, > > On Thu, May 28, 2020 at 12:18:39PM -0700, Jaegeuk Kim wrote: >> On 05/28, Chao Yu wro

Re: [f2fs-dev] [PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

Hi Chao, Can you please help review the diff given by Jaegeuk below? If it looks good, I can post a v2. Thanks, On Thu, May 28, 2020 at 12:18:39PM -0700, Jaegeuk Kim wrote: > On 05/28, Chao Yu wrote: > > On 2020/5/28 10:45, Chao Yu wrote: > > > On 2020/5/27 10:20, Sahitya Tummala wrote: > > >> I

Re: [f2fs-dev] [PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

Hi Chao, Can you please help review below diff given by Jaegeuk? If it looks good, I can send a v2. Thanks, On Thu, May 28, 2020 at 12:18:39PM -0700, Jaegeuk Kim wrote: > On 05/28, Chao Yu wrote: > > On 2020/5/28 10:45, Chao Yu wrote: > > > On 2020/5/27 10:20, Sahitya Tummala wrote: > > >> In ca

Re: [f2fs-dev] [PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

On 05/28, Chao Yu wrote: > On 2020/5/28 10:45, Chao Yu wrote: > > On 2020/5/27 10:20, Sahitya Tummala wrote: > >> In case a compressed file is getting overwritten, the current retry > >> logic doesn't include the current page to be retried now as it sets > >> the new start index as 0 and new end in

Re: [f2fs-dev] [PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

On 2020/5/28 10:45, Chao Yu wrote: > On 2020/5/27 10:20, Sahitya Tummala wrote: >> In case a compressed file is getting overwritten, the current retry >> logic doesn't include the current page to be retried now as it sets >> the new start index as 0 and new end index as writeback_index - 1. >> This

Re: [PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

On 2020/5/27 10:20, Sahitya Tummala wrote: > In case a compressed file is getting overwritten, the current retry > logic doesn't include the current page to be retried now as it sets > the new start index as 0 and new end index as writeback_index - 1. > This causes the corresponding cluster to be u

[PATCH] f2fs: fix retry logic in f2fs_write_cache_pages()

In case a compressed file is getting overwritten, the current retry logic doesn't include the current page to be retried now as it sets the new start index as 0 and new end index as writeback_index - 1. This causes the corresponding cluster to be uncompressed and written as normal pages without com