Re: [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context

2020-06-15 Thread Sahitya Tummala
On Mon, Jun 15, 2020 at 08:47:20AM -0700, Eric Biggers wrote: > On Mon, Jun 15, 2020 at 03:23:16PM +0530, Sahitya Tummala wrote: > > > > > > Should I fold this change into the original patch? Or keep it as a > > > separate patch when I send out the fscrypt/f2fs inline encryption > > > patches? > >

Re: [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context

2020-06-15 Thread Eric Biggers
On Mon, Jun 15, 2020 at 03:23:16PM +0530, Sahitya Tummala wrote: > > > > Should I fold this change into the original patch? Or keep it as a > > separate patch when I send out the fscrypt/f2fs inline encryption > > patches? > > It may be good to keep it seperate as we already have the base FBE pat

Re: [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context

2020-06-15 Thread Sahitya Tummala
Hi Satya, On Mon, Jun 15, 2020 at 06:16:33AM +, Satya Tangirala wrote: > On Sun, Jun 14, 2020 at 10:00:19PM -0700, Eric Biggers wrote: > > On Mon, Jun 15, 2020 at 09:29:48AM +0530, Sahitya Tummala wrote: > > > There could be a potential race between these two paths below, > > > leading to use-

Re: [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context

2020-06-15 Thread Sahitya Tummala
Hi Eric, On Sun, Jun 14, 2020 at 10:00:19PM -0700, Eric Biggers wrote: > On Mon, Jun 15, 2020 at 09:29:48AM +0530, Sahitya Tummala wrote: > > There could be a potential race between these two paths below, > > leading to use-after-free when accessing bio->bi_crypt_context. > > > > f2fs_write_cache