Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-25 Thread Chao Yu
On 2016/9/25 1:47, Jaegeuk Kim wrote: > On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote: >> On 2016/9/24 5:11, Jaegeuk Kim wrote: >>> When getting EIO while handling orphan inodes, we can get some dirty node >>> pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try >>>

Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-25 Thread Chao Yu
On 2016/9/25 1:47, Jaegeuk Kim wrote: > On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote: >> On 2016/9/24 5:11, Jaegeuk Kim wrote: >>> When getting EIO while handling orphan inodes, we can get some dirty node >>> pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try >>>

Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-24 Thread Jaegeuk Kim
On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote: > On 2016/9/24 5:11, Jaegeuk Kim wrote: > > When getting EIO while handling orphan inodes, we can get some dirty node > > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try > > to flush node pages. But in this case, we

Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-24 Thread Jaegeuk Kim
On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote: > On 2016/9/24 5:11, Jaegeuk Kim wrote: > > When getting EIO while handling orphan inodes, we can get some dirty node > > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try > > to flush node pages. But in this case, we

Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-23 Thread Chao Yu
On 2016/9/24 5:11, Jaegeuk Kim wrote: > When getting EIO while handling orphan inodes, we can get some dirty node > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try > to flush node pages. But in this case, we should prevent to do that, since > we will try again from the

Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-23 Thread Chao Yu
On 2016/9/24 5:11, Jaegeuk Kim wrote: > When getting EIO while handling orphan inodes, we can get some dirty node > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try > to flush node pages. But in this case, we should prevent to do that, since > we will try again from the

[PATCH] f2fs: remove dirty inode pages in error path

2016-09-23 Thread Jaegeuk Kim
When getting EIO while handling orphan inodes, we can get some dirty node pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try to flush node pages. But in this case, we should prevent to do that, since we will try again from the start. Signed-off-by: Jaegeuk Kim

[PATCH] f2fs: remove dirty inode pages in error path

2016-09-23 Thread Jaegeuk Kim
When getting EIO while handling orphan inodes, we can get some dirty node pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try to flush node pages. But in this case, we should prevent to do that, since we will try again from the start. Signed-off-by: Jaegeuk Kim ---