Re: [PATCH] f2fs-tools: support inode checksum

2017-08-03 Thread Chao Yu
Hi Jaegeuk, On 2017/8/4 9:38, Jaegeuk Kim wrote: > Hi Chao, > > It seems three is missing case when verifying the checksum, if the page is > got from cache with some updates. We need to verify it when actually reading > the node block. Agreed. > > Let me modify your patch like this. Is that ok

Re: [PATCH] f2fs-tools: support inode checksum

2017-08-03 Thread Jaegeuk Kim
Hi Chao, It seems three is missing case when verifying the checksum, if the page is got from cache with some updates. We need to verify it when actually reading the node block. Let me modify your patch like this. Is that okay for you? Thanks, --- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/inode.c |

Re: [PATCH] f2fs-tools: support inode checksum

2017-07-26 Thread Chao Yu
Hi Jaegeuk, On 2017/7/27 5:40, Jaegeuk Kim wrote: > Hi Chao, > > Just for testing purpose, I filed them in dev-test.git. > Note that, I fixed two build errors below. Oops, my bad, actually I just note that there is warning in compile flow, I need -Werror anyway during compiling. Thanks for fixi

Re: [PATCH] f2fs-tools: support inode checksum

2017-07-26 Thread Jaegeuk Kim
Hi Chao, Just for testing purpose, I filed them in dev-test.git. Note that, I fixed two build errors below. Thanks, On 07/26, Chao Yu wrote: > From: Chao Yu > > This patch introduce a new option 'inode_checksum' for enabling inode > checksum functionality in mkfs/fsck/sload. > > Signed-off-by

[PATCH] f2fs-tools: support inode checksum

2017-07-26 Thread Chao Yu
From: Chao Yu This patch introduce a new option 'inode_checksum' for enabling inode checksum functionality in mkfs/fsck/sload. Signed-off-by: Chao Yu --- fsck/dir.c | 4 fsck/fsck.c | 27 +-- fsck/mount.c| 9 + fsck/se