Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-17 Thread Wei Liu
On Sun, Jan 17, 2021 at 03:32:17PM +0100, Greg Kroah-Hartman wrote: > On Sun, Jan 17, 2021 at 02:21:27PM +, Wei Liu wrote: > > On Sun, Jan 17, 2021 at 09:29:42AM +0100, Greg Kroah-Hartman wrote: > > > On Sat, Jan 16, 2021 at 12:11:09PM +, Wei Liu wrote: > > > > On Sat, Jan 16, 2021 at 11:55

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-17 Thread Greg Kroah-Hartman
On Sun, Jan 17, 2021 at 02:21:27PM +, Wei Liu wrote: > On Sun, Jan 17, 2021 at 09:29:42AM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 16, 2021 at 12:11:09PM +, Wei Liu wrote: > > > On Sat, Jan 16, 2021 at 11:55:29AM +, Wei Liu wrote: > > > > On Fri, Jan 15, 2021 at 04:49:57PM -0800

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-17 Thread Wei Liu
On Sun, Jan 17, 2021 at 09:29:42AM +0100, Greg Kroah-Hartman wrote: > On Sat, Jan 16, 2021 at 12:11:09PM +, Wei Liu wrote: > > On Sat, Jan 16, 2021 at 11:55:29AM +, Wei Liu wrote: > > > On Fri, Jan 15, 2021 at 04:49:57PM -0800, Randy Dunlap wrote: > > > > Hi, > > > > > > > > On 1/15/21 4:1

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 16, 2021 at 12:11:09PM +, Wei Liu wrote: > On Sat, Jan 16, 2021 at 11:55:29AM +, Wei Liu wrote: > > On Fri, Jan 15, 2021 at 04:49:57PM -0800, Randy Dunlap wrote: > > > Hi, > > > > > > On 1/15/21 4:12 PM, Wei Liu wrote: > > > > For built-in drivers, the order of initialization f

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-16 Thread Wei Liu
On Sat, Jan 16, 2021 at 11:55:29AM +, Wei Liu wrote: > On Fri, Jan 15, 2021 at 04:49:57PM -0800, Randy Dunlap wrote: > > Hi, > > > > On 1/15/21 4:12 PM, Wei Liu wrote: > > > For built-in drivers, the order of initialization function invocation is > > > determined by their link order. > > > >

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-16 Thread Wei Liu
On Fri, Jan 15, 2021 at 04:49:57PM -0800, Randy Dunlap wrote: > Hi, > > On 1/15/21 4:12 PM, Wei Liu wrote: > > For built-in drivers, the order of initialization function invocation is > > determined by their link order. > > > > The original code linked TPM drivers before TEE driver when they were

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-15 Thread kernel test robot
Hi Wei, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-15 Thread kernel test robot
Hi Wei, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on soc/for-next linus/master v5.11-rc3 next-20210115] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' a

Re: [PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-15 Thread Randy Dunlap
Hi, On 1/15/21 4:12 PM, Wei Liu wrote: > For built-in drivers, the order of initialization function invocation is > determined by their link order. > > The original code linked TPM drivers before TEE driver when they were > both built in. That caused fTPM's initialization to be deferred to a > wo

[PATCH] fTPM: make sure TEE is initialized before fTPM

2021-01-15 Thread Wei Liu
For built-in drivers, the order of initialization function invocation is determined by their link order. The original code linked TPM drivers before TEE driver when they were both built in. That caused fTPM's initialization to be deferred to a worker thread instead of running on PID 1. That is pr