Re: [PATCH] fat: Refactor shortname parsing

2012-08-03 Thread Steven J. Magnani
On Fri, 2012-08-03 at 17:58 +0200, Jan Engelhardt wrote: > On Friday 2012-08-03 17:06, OGAWA Hirofumi wrote: > >>>+static inline unsigned char fat_tolower(unsigned char c) > >>>+{ > >>>+ return ((c >= 'A') && (c <= 'Z')) ? c+32 : c; > >>>+} > >>>+ > >> > >> The kernel already has a tolower() func

Re: [PATCH] fat: Refactor shortname parsing

2012-08-03 Thread Jan Engelhardt
On Friday 2012-08-03 17:06, OGAWA Hirofumi wrote: >>>+static inline unsigned char fat_tolower(unsigned char c) >>>+{ >>>+return ((c >= 'A') && (c <= 'Z')) ? c+32 : c; >>>+} >>>+ >> >> The kernel already has a tolower() function, can that not be used? > >tolower() is not exactly same, right? e.

Re: [PATCH] fat: Refactor shortname parsing

2012-08-03 Thread OGAWA Hirofumi
Jan Engelhardt writes: > On Tuesday 2012-07-03 13:14, Steven J. Magnani wrote: > >>Nearly identical shortname parsing is performed in fat_search_long() >>and __fat_readdir(). Extract this code into a function that may be >>called by both. >> >>v2: Attempt to clarify difference between vfat and ms

Re: [PATCH] fat: Refactor shortname parsing

2012-08-03 Thread Jan Engelhardt
On Tuesday 2012-07-03 13:14, Steven J. Magnani wrote: >Nearly identical shortname parsing is performed in fat_search_long() >and __fat_readdir(). Extract this code into a function that may be >called by both. > >v2: Attempt to clarify difference between vfat and msdos parsing. >Remove decision