Re: [PATCH] fat: Support fallocate on fat.

2012-07-12 Thread OGAWA Hirofumi
Namjae Jeon writes: >> I guess, if Windows truncates the above clusters than file size, it may >> be prefer to truncate on linux too. We really need it over umount? >> We never know the file whether corrupted or preallocated. >> >> And at least for now, it would be better to put under CONFIG_FAT_

Re: [PATCH] fat: Support fallocate on fat.

2012-07-10 Thread Namjae Jeon
2012/7/9, OGAWA Hirofumi : > Namjae Jeon writes: > >> 2012/7/9, OGAWA Hirofumi : >>> Namjae Jeon writes: >>> >> +/* >> + * calculate i_blocks and mmu_private from the actual number of >> + * allocated clusters instead of doing it from file size.This >> ensu

Re: [PATCH] fat: Support fallocate on fat.

2012-07-09 Thread OGAWA Hirofumi
Namjae Jeon writes: > 2012/7/9, OGAWA Hirofumi : >> Namjae Jeon writes: >> > + /* > + * calculate i_blocks and mmu_private from the actual number of > + * allocated clusters instead of doing it from file size.This ensures > + * that the preallocated disk space using FALLOC_FL_

Re: [PATCH] fat: Support fallocate on fat.

2012-07-09 Thread Namjae Jeon
2012/7/9, OGAWA Hirofumi : > Namjae Jeon writes: > + /* + * calculate i_blocks and mmu_private from the actual number of + * allocated clusters instead of doing it from file size.This ensures + * that the preallocated disk space using FALLOC_FL_KEEP_SIZE is + * pe

Re: [PATCH] fat: Support fallocate on fat.

2012-07-09 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> + /* >>> +* calculate i_blocks and mmu_private from the actual number of >>> +* allocated clusters instead of doing it from file size.This ensures >>> +* that the preallocated disk space using FALLOC_FL_KEEP_SIZE is >>> +* persistent across remounts and w

Re: [PATCH] fat: Support fallocate on fat.

2012-07-08 Thread Namjae Jeon
Hi. Ogawa. 2012/7/8, OGAWA Hirofumi : > Namjae Jeon writes: > >> +/* >> + * preallocate space for a file. This implements fat's fallocate file >> + * operation, which gets called from sys_fallocate system call. User >> + * space requests len bytes at offset.If FALLOC_FL_KEEP_SIZE is set >> + * we

Re: [PATCH] fat: Support fallocate on fat.

2012-07-08 Thread OGAWA Hirofumi
Namjae Jeon writes: > +/* > + * preallocate space for a file. This implements fat's fallocate file > + * operation, which gets called from sys_fallocate system call. User > + * space requests len bytes at offset.If FALLOC_FL_KEEP_SIZE is set > + * we just allocate clusters without zeroing them ou

[PATCH] fat: Support fallocate on fat.

2012-07-07 Thread Namjae Jeon
Implement preallocation via the fallocate syscall on VFAT partitions. This patch is based on an earlier patch of the same name which had some issues detailed below and did not get accepted. Refer https://lkml.org/lkml/2007/12/22/130. a)The preallocated space was not persistent across remounts when