Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds

2007-11-07 Thread OGAWA Hirofumi
Olof Johansson <[EMAIL PROTECTED]> writes: > Annoying gcc warning: > > fs/fat/inode.c: In function 'fat_fill_super': > fs/fat/inode.c:1222: warning: comparison is always false due to limited range > of data type > > Change it to compare with 4K instead of PAGE_CACHE_SIZE, as suggested > by OGAWA-

Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds

2007-11-07 Thread Olof Johansson
Annoying gcc warning: fs/fat/inode.c: In function 'fat_fill_super': fs/fat/inode.c:1222: warning: comparison is always false due to limited range of data type Change it to compare with 4K instead of PAGE_CACHE_SIZE, as suggested by OGAWA-san. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>

Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds

2007-11-07 Thread OGAWA Hirofumi
Olof Johansson <[EMAIL PROTECTED]> writes: > logical_sector_size can never be more than 16 bits worth, but switching > it to an int silences gcc. It's a sanity check that can never fail with > 64KB PAGE_SIZE but it seems like it'd still be useful for other page > sizes, so it's worth keeping: > >

[PATCH] fat: silence warning for 64KB PAGE_SIZE builds

2007-11-06 Thread Olof Johansson
Annoying gcc warning: fs/fat/inode.c: In function 'fat_fill_super': fs/fat/inode.c:1222: warning: comparison is always false due to limited range of data type logical_sector_size can never be more than 16 bits worth, but switching it to an int silences gcc. It's a sanity check that can never fai