RE: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-06-11 Thread Chintakuntla, Radha
; > Dann Frazier ; Peter Hurley > ; Pavel Machek ; Jonathan Liu > ; Alistair Popple ; Jean-Philippe > Brucker ; Chintakuntla, Radha > ; Jiri Slaby ; David > Airlie ; David Daney ; dri- > de...@lists.freedesktop.org; linux-fb...@vger.kernel.org; Linux Kernel > Mailing List ;

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-28 Thread Henrique de Moraes Holschuh
On Fri, 20 May 2016, Scot Doyle wrote: > On Fri, 20 May 2016, Jeremy Kerr wrote: > > >Then looks there are two fix patches acked & tested: > > > > > > - the patch in this thread > > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > > >blink timer." > > > https://lkml.org/lkml/2016

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-28 Thread Henrique de Moraes Holschuh
On Thu, 19 May 2016, Scot Doyle wrote: > Two systems are locking on boot [1] because ops->cur_blink_jiffies > is set to zero from vc->vc_cur_blink_ms. > > Ignore such invalid intervals and log a warning. > > [1] https://bugs.launchpad.net/bugs/1574814 > > Suggested-by: David Daney > Signed-off-

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-23 Thread Scot Doyle
On Fri, 20 May 2016, Scot Doyle wrote: > On Fri, 20 May 2016, Jeremy Kerr wrote: > > Hi Ming, > > > > >Then looks there are two fix patches acked & tested: > > > > > > - the patch in this thread > > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > > >blink timer." > > > https://

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-20 Thread Scot Doyle
On Fri, 20 May 2016, Jeremy Kerr wrote: > Hi Ming, > > >Then looks there are two fix patches acked & tested: > > > > - the patch in this thread > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > >blink timer." > > https://lkml.org/lkml/2016/5/17/455 > > > >So which one will be p

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread Jeremy Kerr
Hi Ming, >Then looks there are two fix patches acked & tested: > > - the patch in this thread > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor >blink timer." > https://lkml.org/lkml/2016/5/17/455 > >So which one will be pushed to linus? Not that it's my call, but we may want both

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread Ming Lei
On Fri, May 20, 2016 at 10:26 AM, Jeremy Kerr wrote: > Hi Ming, > >> Not sure this one is needed for stable because it justs dumps >> a warning, and not set a valid period to ops->cur_blink_jiffies. >> >> So I guess other fix patch is still required for the soft lockup >> issue, right? > > The mai

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread Jeremy Kerr
Hi Ming, > Not sure this one is needed for stable because it justs dumps > a warning, and not set a valid period to ops->cur_blink_jiffies. > > So I guess other fix patch is still required for the soft lockup > issue, right? The main thing is that we don't set cur_blink_jiffies to the < 50ms val

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread Ming Lei
On Fri, May 20, 2016 at 6:31 AM, Scot Doyle wrote: > Two systems are locking on boot [1] because ops->cur_blink_jiffies > is set to zero from vc->vc_cur_blink_ms. > > Ignore such invalid intervals and log a warning. > > [1] https://bugs.launchpad.net/bugs/1574814 > > Suggested-by: David Daney > S

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread Jeremy Kerr
Hi Scot, > Two systems are locking on boot [1] because ops->cur_blink_jiffies > is set to zero from vc->vc_cur_blink_ms. > > Ignore such invalid intervals and log a warning. This prevents a lockup on AST BMC machines, but (as expected) generates a warning against the fbcon driver, which is a sig

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread David Daney
On 05/19/2016 03:31 PM, Scot Doyle wrote: Two systems are locking on boot [1] because ops->cur_blink_jiffies is set to zero from vc->vc_cur_blink_ms. Ignore such invalid intervals and log a warning. [1] https://bugs.launchpad.net/bugs/1574814 Suggested-by: David Daney Signed-off-by: Scot Doyl

[PATCH] fbcon: warn on invalid cursor blink intervals

2016-05-19 Thread Scot Doyle
Two systems are locking on boot [1] because ops->cur_blink_jiffies is set to zero from vc->vc_cur_blink_ms. Ignore such invalid intervals and log a warning. [1] https://bugs.launchpad.net/bugs/1574814 Suggested-by: David Daney Signed-off-by: Scot Doyle Cc: [v4.2] --- drivers/video/console/fb