> > No, bits_per_pixel can be (much) larger than the color map size. E.g. a
> > simple
> > ARGB directcolor mode has bits_per_pixel = 32 and color map size = 256.
>
> So I have the bits_per_pixel attribute wrong in sysfs. It needs to be
> bits_per_color and then let the driver sort it out.
> > 3) Add another file in sysfs which specifies at what index and how many
> > entries will be read or written from or to the cmap. With this additional
> > sysfs file, it should be able to handle any reasonable cmap length, but
> > it will take more than one reading of the color_map file.
On 7/29/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> On Fri, 29 Jul 2005, Antonino A. Daplas wrote:
> > Jon Smirl wrote:
> > > On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > > > On Thu, 28 Jul 2005, Jon Smirl wrote:
> > > > > I've verified now that all ATI R300+ chips have
On Fri, 29 Jul 2005, Antonino A. Daplas wrote:
> Jon Smirl wrote:
> > On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > > On Thu, 28 Jul 2005, Jon Smirl wrote:
> > > > I've verified now that all ATI R300+ chips have 10bit cmaps. These are
> > > > pretty common so I'd be in favor of
On Fri, 29 Jul 2005, Antonino A. Daplas wrote:
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a
On 7/29/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Fri, 29 Jul 2005, Antonino A. Daplas wrote:
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I've verified now that all ATI R300+ chips have 10bit cmaps. These
3) Add another file in sysfs which specifies at what index and how many
entries will be read or written from or to the cmap. With this additional
sysfs file, it should be able to handle any reasonable cmap length, but
it will take more than one reading of the color_map file. Another
No, bits_per_pixel can be (much) larger than the color map size. E.g. a
simple
ARGB directcolor mode has bits_per_pixel = 32 and color map size = 256.
So I have the bits_per_pixel attribute wrong in sysfs. It needs to be
bits_per_color and then let the driver sort it out.
Geert Uytterhoeven wrote:
On Thu, 28 Jul 2005, Antonino A. Daplas wrote:
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a check to limit use of the sysfs
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a binary
attribute where I can get/set the whole table at
Jon Smirl wrote:
Can you review this fix for the issues below? I fixed things to
automatically adjust the number of entries to whatever fits in
PAGE_SIZE.
diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
--- a/drivers/video/fbsysfs.c
+++ b/drivers/video/fbsysfs.c
@@ -244,15
On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> On Thu, 28 Jul 2005, Jon Smirl wrote:
> > I've verified now that all ATI R300+ chips have 10bit cmaps. These are
> > pretty common so I'd be in favor of making this into a binary
> > attribute where I can get/set the whole table at once.
On Thu, 28 Jul 2005, Jon Smirl wrote:
> I've verified now that all ATI R300+ chips have 10bit cmaps. These are
> pretty common so I'd be in favor of making this into a binary
> attribute where I can get/set the whole table at once. Given that
> OpenGL is already supporting 12 and 16 bits these
On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> On Thu, 28 Jul 2005, Jon Smirl wrote:
> > I can't see a way to query how long of cmap the device supports using
> > the current fbdev ioctls.
>
> Look at the lengths of the color bitfields?
Which color bitfields? Does hardware that
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a binary
attribute where I can get/set the whole table at once. Given that
OpenGL is already supporting 12 and 16 bits these tables are only
going to get much larger.
1024
On 7/28/05, Jon Smirl <[EMAIL PROTECTED]> wrote:
> On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > On Thu, 28 Jul 2005, Jon Smirl wrote:
> > > I can't see a way to query how long of cmap the device supports using
> > > the current fbdev ioctls.
> >
> > Look at the lengths of the
On Thu, 28 Jul 2005, Jon Smirl wrote:
> I can't see a way to query how long of cmap the device supports using
> the current fbdev ioctls.
Look at the lengths of the color bitfields?
> I wouldn't even be messing with cmap except for the true/direct color
> support and gamma ramps. Don't I need to
On Thu, 28 Jul 2005, Jon Smirl wrote:
> Do we want to apply this patch now to get rid of the buffer overflow hole?
IMHO, yes please.
> Then we can take our time and work out a better solution.
Indeed.
> Fix a buffer overflow vunerabilty in previous cmap patch
> signed-off-by: Jon Smirl <[EMAIL
Do we want to apply this patch now to get rid of the buffer overflow hole?
Then we can take our time and work out a better solution.
--
Jon Smirl
[EMAIL PROTECTED]
Fix a buffer overflow vunerabilty in previous cmap patch
signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
diff --git
I can't see a way to query how long of cmap the device supports using
the current fbdev ioctls.
I wouldn't even be messing with cmap except for the true/direct color
support and gamma ramps. Don't I need to know how long the cmap is in
order to set the right gamma ramp?
If I set a 256 entry
On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> On Thu, 28 Jul 2005, Antonino A. Daplas wrote:
> > Jon Smirl wrote:
> > > On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > > > On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
> > >
> > > There are a couple of ways to
On Thu, 28 Jul 2005, Jon Smirl wrote:
> Can you review this fix for the issues below? I fixed things to
> automatically adjust the number of entries to whatever fits in
> PAGE_SIZE.
Looks OK, but...
> @@ -317,18 +317,18 @@ static ssize_t show_cmap(struct class_de
> !fb_info->cmap.green)
On Thu, 28 Jul 2005, Antonino A. Daplas wrote:
> Jon Smirl wrote:
> > On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > > On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
> >
> > There are a couple of ways to fix this.
> > 1) Add a check to limit use of the sysfs attributes to
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a check to limit use of the sysfs attributes to 256 entries. If
you want more you have to use /dev/fb0 and the
gt; On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
> > tree 17014af0ea8b19dae7848736d324499715b7a1a3
> > parent 3ca34fcbfbf8a7cbe99d54ae81c4e28fdc6f4ac6
> > author Jon Smirl <[EMAIL PROTECTED]> Thu, 28 Jul 2005 01:46:05 -0700
> > committer Linus Torvalds <[EMAIL PROTECTED]&g
On Thu, 28 Jul 2005, Jon Smirl wrote:
> On 7/28/05, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
>
> There are a couple of ways to fix this.
>
> 1) Add a check to limit use of the sysfs attributes to 256 entries. If
> you want more you
orvalds <[EMAIL PROTECTED]> Thu, 28 Jul 2005 06:26:18 -0700
> >
> > [PATCH] fbdev: colormap fixes
> >
> > Color maps have up to 256 entries. 4096/256 allows for 16 characters per
> ^^
> Most (all?) current drivers have this limitati
hu, 28 Jul 2005 06:26:18 -0700
>
> [PATCH] fbdev: colormap fixes
>
> Color maps have up to 256 entries. 4096/256 allows for 16 characters per
^^
Most (all?) current drivers have this limitation. But there exists hardware
with more entries.
> line. Th
[PATCH] fbdev: colormap fixes
Color maps have up to 256 entries. 4096/256 allows for 16 characters per
^^
Most (all?) current drivers have this limitation. But there exists hardware
with more entries.
line. The format for a cmap entry is %02x%c%4x%4x%4x\n %02x
-0700
[PATCH] fbdev: colormap fixes
Color maps have up to 256 entries. 4096/256 allows for 16 characters per
^^
Most (all?) current drivers have this limitation. But there exists hardware
with more entries.
line. The format for a cmap entry is %02x%c%4x
On Thu, 28 Jul 2005, Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a check to limit use of the sysfs attributes to 256 entries. If
you want more you have to
PROTECTED] Thu, 28 Jul 2005 01:46:05 -0700
committer Linus Torvalds [EMAIL PROTECTED] Thu, 28 Jul 2005 06:26:18 -0700
[PATCH] fbdev: colormap fixes
Color maps have up to 256 entries. 4096/256 allows for 16 characters per
^^
Most (all?) current drivers have
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a check to limit use of the sysfs attributes to 256 entries. If
you want more you have to use /dev/fb0 and the
On Thu, 28 Jul 2005, Antonino A. Daplas wrote:
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a check to limit use of the sysfs attributes to 256 entries. If
On Thu, 28 Jul 2005, Jon Smirl wrote:
Can you review this fix for the issues below? I fixed things to
automatically adjust the number of entries to whatever fits in
PAGE_SIZE.
Looks OK, but...
@@ -317,18 +317,18 @@ static ssize_t show_cmap(struct class_de
!fb_info-cmap.green)
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Antonino A. Daplas wrote:
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a
I can't see a way to query how long of cmap the device supports using
the current fbdev ioctls.
I wouldn't even be messing with cmap except for the true/direct color
support and gamma ramps. Don't I need to know how long the cmap is in
order to set the right gamma ramp?
If I set a 256 entry
Do we want to apply this patch now to get rid of the buffer overflow hole?
Then we can take our time and work out a better solution.
--
Jon Smirl
[EMAIL PROTECTED]
Fix a buffer overflow vunerabilty in previous cmap patch
signed-off-by: Jon Smirl [EMAIL PROTECTED]
diff --git
On Thu, 28 Jul 2005, Jon Smirl wrote:
Do we want to apply this patch now to get rid of the buffer overflow hole?
IMHO, yes please.
Then we can take our time and work out a better solution.
Indeed.
Fix a buffer overflow vunerabilty in previous cmap patch
signed-off-by: Jon Smirl [EMAIL
On Thu, 28 Jul 2005, Jon Smirl wrote:
I can't see a way to query how long of cmap the device supports using
the current fbdev ioctls.
Look at the lengths of the color bitfields?
I wouldn't even be messing with cmap except for the true/direct color
support and gamma ramps. Don't I need to
On 7/28/05, Jon Smirl [EMAIL PROTECTED] wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I can't see a way to query how long of cmap the device supports using
the current fbdev ioctls.
Look at the lengths of the color bitfields?
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a binary
attribute where I can get/set the whole table at once. Given that
OpenGL is already supporting 12 and 16 bits these tables are only
going to get much larger.
1024
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I can't see a way to query how long of cmap the device supports using
the current fbdev ioctls.
Look at the lengths of the color bitfields?
Which color bitfields? Does hardware that supports
On Thu, 28 Jul 2005, Jon Smirl wrote:
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a binary
attribute where I can get/set the whole table at once. Given that
OpenGL is already supporting 12 and 16 bits these tables
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a binary
attribute where I can get/set the whole table at once. Given
Jon Smirl wrote:
Can you review this fix for the issues below? I fixed things to
automatically adjust the number of entries to whatever fits in
PAGE_SIZE.
diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
--- a/drivers/video/fbsysfs.c
+++ b/drivers/video/fbsysfs.c
@@ -244,15
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Thu, 28 Jul 2005, Jon Smirl wrote:
I've verified now that all ATI R300+ chips have 10bit cmaps. These are
pretty common so I'd be in favor of making this into a binary
attribute where I can get/set the whole table at
Geert Uytterhoeven wrote:
On Thu, 28 Jul 2005, Antonino A. Daplas wrote:
Jon Smirl wrote:
On 7/28/05, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
There are a couple of ways to fix this.
1) Add a check to limit use of the sysfs attributes
48 matches
Mail list logo
