Romain Dolbeau wrote:
> If on your console you do a 'fbset -depth 16 -rgba 5,6,5,0' followed by
> a 'fbset -depth 16 -rgba 5,5,5,1' [1], any driver using fbdev will end
That should have been 'fbgen', sorry for the momentary lapse o
> This happens every time you VC switch.
[snip]
> But because of the way the current console system
> is designed the colormap will always be set on VC switches.
The fix wasn't intended for VC switch, but for any change of
fb_var_screeninfo parameter. Those can happen without VC switching,
that's
> For the color component, yes, but you can't use a memcmp
> on the 'fb_var_screeninfo', as some member of the struct
> are irrelevant to colormap switching (you don't want
> to reinstall the colormap if only the refresh rate changed,
> for instance).
But it does. If you look at the console code
Romain Dolbeau wrote:
> the attached patch fix a problem with fbgen when changing the
> RGBA components but not the depth ; fbgen would not change
> the colormap in this case, where it should.
This is the same patch but using memcmp() on the 3 color
components.
--
DOLBEAU Romain
James Simmons wrote:
>
> > the attached patch fix a problem with fbgen when changing the
> > RGBA components but not the depth ; fbgen would not change
> > the colormap in this case, where it should.
>
> It would be much easier to use a memcmp.
For the color component, yes, but you can't use a
> the attached patch fix a problem with fbgen when changing the
> RGBA components but not the depth ; fbgen would not change
> the colormap in this case, where it should.
It would be much easier to use a memcmp.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
Hello,
the attached patch fix a problem with fbgen when changing the
RGBA components but not the depth ; fbgen would not change
the colormap in this case, where it should.
--
romain
fbgen.patch.gz
7 matches
Mail list logo
