Re: [PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var()

2020-07-30 Thread Daniel Vetter
On Thu, Jul 30, 2020 at 1:27 PM Tetsuo Handa wrote: > > On 2020/07/30 20:16, Daniel Vetter wrote: > > Patch looks good, except ... does this compile? fbcon_update_vcs is > > defined in fbcon.h, and that doesn't seem to be included here ... > > Maybe what we want is an fb_set_var_ioctl in fbmem.c

Re: [PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var()

2020-07-30 Thread Tetsuo Handa
On 2020/07/30 20:16, Daniel Vetter wrote: > Patch looks good, except ... does this compile? fbcon_update_vcs is > defined in fbcon.h, and that doesn't seem to be included here ... > Maybe what we want is an fb_set_var_ioctl in fbmem.c so that the fbcon > interaction is a bit better hidden (but

Re: [PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var()

2020-07-30 Thread Daniel Vetter
On Thu, Jul 30, 2020 at 12:47 AM Tetsuo Handa wrote: > > syzbot is reporting OOB read bug in vc_do_resize() [1] caused by memcpy() > based on outdated old_{rows,row_size} values, for resize_screen() can > recurse into vc_do_resize() which changes vc->vc_{cols,rows} that outdates >

[PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var()

2020-07-29 Thread Tetsuo Handa
syzbot is reporting OOB read bug in vc_do_resize() [1] caused by memcpy() based on outdated old_{rows,row_size} values, for resize_screen() can recurse into vc_do_resize() which changes vc->vc_{cols,rows} that outdates old_{rows,row_size} values which were saved before calling resize_screen().