Re: [PATCH] firewire: Remove function callback casts

2020-05-19 Thread Oscar Carter
On Sun, May 17, 2020 at 07:43:21PM +0300, Lev R. Oshvang . wrote: > > Hi Oscar, > I would recommend to explicitly set NULL to _cb and use if elif to > exclude the case where botm _cb paraneters are passed as NULLs : > > + > ctx->callback.mc =NULL: > ctx->callback.sc = NULL; > > + if (cb_s

Re: [PATCH] firewire: Remove function callback casts

2020-05-17 Thread Lev R. Oshvang .
On Sat, May 16, 2020 at 8:40 PM Oscar Carter wrote: > > In an effort to enable -Wcast-function-type in the top-level Makefile to > support Control Flow Integrity builds, remove all the function callback > casts. > > To do this, modify the "fw_iso_context_create" function prototype adding > a new p

[PATCH] firewire: Remove function callback casts

2020-05-16 Thread Oscar Carter
In an effort to enable -Wcast-function-type in the top-level Makefile to support Control Flow Integrity builds, remove all the function callback casts. To do this, modify the "fw_iso_context_create" function prototype adding a new parameter for the multichannel callback. Also, fix all the function