Re: dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation)

2007-11-01 Thread Nick Piggin
On Thursday 01 November 2007 20:51, Stefan Richter wrote: > Nick Piggin wrote: > > On Thursday 01 November 2007 12:49, Stefan Richter wrote: > >> fw_device.node_id and fw_device.generation are accessed without mutexes. > >> We have to ensure that all readers will get to see node_id updates > >>

dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation)

2007-11-01 Thread Stefan Richter
Nick Piggin wrote: > On Thursday 01 November 2007 12:49, Stefan Richter wrote: >> fw_device.node_id and fw_device.generation are accessed without mutexes. >> We have to ensure that all readers will get to see node_id updates >> before generation updates. >> > > Hi, a few points: Thanks, this is

dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation)

2007-11-01 Thread Stefan Richter
Nick Piggin wrote: On Thursday 01 November 2007 12:49, Stefan Richter wrote: fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. Hi, a few points: Thanks, this is

Re: dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation)

2007-11-01 Thread Nick Piggin
On Thursday 01 November 2007 20:51, Stefan Richter wrote: Nick Piggin wrote: On Thursday 01 November 2007 12:49, Stefan Richter wrote: fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before

Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation

2007-10-31 Thread Nick Piggin
On Thursday 01 November 2007 12:49, Stefan Richter wrote: > fw_device.node_id and fw_device.generation are accessed without mutexes. > We have to ensure that all readers will get to see node_id updates > before generation updates. > Hi, a few points: - can change it to use spinlocks instead?

[PATCH] firewire: fw-core: enforce write order when updating fw_device.generation

2007-10-31 Thread Stefan Richter
fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-device.c |6 ++

[PATCH] firewire: fw-core: enforce write order when updating fw_device.generation

2007-10-31 Thread Stefan Richter
fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- drivers/firewire/fw-device.c |6 ++ drivers/firewire/fw-topology.c

Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation

2007-10-31 Thread Nick Piggin
On Thursday 01 November 2007 12:49, Stefan Richter wrote: fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. Hi, a few points: - can change it to use spinlocks instead? This