Re: [PATCH] firewire: prevent integer overflow on 32bit systems

2021-03-03 Thread kernel test robot
Hi Dan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.12-rc1 next-20210303] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base'

Re: [PATCH] firewire: prevent integer overflow on 32bit systems

2021-03-03 Thread Dan Carpenter
On Tue, Mar 02, 2021 at 10:19:11PM +0100, Stefan Richter wrote: > On Mar 02 Dan Carpenter wrote: > > In TCODE_STREAM_DATA mode, on 32bit systems, the "sizeof(*e) + > > request->length" operation can overflow leading to memory corruption. > > > > Fixes: 18e9b10fcdc0 ("firewire: cdev: add closure to

Re: [PATCH] firewire: prevent integer overflow on 32bit systems

2021-03-02 Thread Stefan Richter
On Mar 02 Dan Carpenter wrote: > In TCODE_STREAM_DATA mode, on 32bit systems, the "sizeof(*e) + > request->length" operation can overflow leading to memory corruption. > > Fixes: 18e9b10fcdc0 ("firewire: cdev: add closure to async stream ioctl") > Signed-off-by: Dan Carpenter > --- > drivers/fir

[PATCH] firewire: prevent integer overflow on 32bit systems

2021-03-02 Thread Dan Carpenter
In TCODE_STREAM_DATA mode, on 32bit systems, the "sizeof(*e) + request->length" operation can overflow leading to memory corruption. Fixes: 18e9b10fcdc0 ("firewire: cdev: add closure to async stream ioctl") Signed-off-by: Dan Carpenter --- drivers/firewire/core-cdev.c | 3 +++ 1 file changed, 3