Re: [PATCH] firewire: sbp2: Replace GFP_ATOMIC with GFP_KERNEL in sbp2_scsi_queuecommand()

2018-07-23 Thread Jia-Ju Bai
Thanks for the reply :) On 2018/7/23 20:24, Stefan Richter wrote: Adding Cc: LSML On Jul 23 Jia-Ju Bai wrote: sbp2_scsi_queuecommand() is only set to .queuecommand of "struct scsi_host_template", and this function pointer is never called in atomic context. As far as I remember, scsi_host_tem

[PATCH] firewire: sbp2: Replace GFP_ATOMIC with GFP_KERNEL in sbp2_scsi_queuecommand()

2018-07-23 Thread Jia-Ju Bai
sbp2_scsi_queuecommand() is only set to .queuecommand of "struct scsi_host_template", and this function pointer is never called in atomic context. sbp2_scsi_queuecommand() calls kzalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a stat