Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-05 Thread Kai-Heng Feng
On Thu, Oct 5, 2017 at 5:17 AM, Luis R. Rodriguez wrote: > On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: >> Currently, firmware will only be chached if assign_firmware_buf() gets >> called. > > True, but also more importantly we peg the fw cache to the device

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-05 Thread Kai-Heng Feng
On Thu, Oct 5, 2017 at 5:17 AM, Luis R. Rodriguez wrote: > On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: >> Currently, firmware will only be chached if assign_firmware_buf() gets >> called. > > True, but also more importantly we peg the fw cache to the device via devres > *iff*

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-04 Thread Luis R. Rodriguez
On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. True, but also more importantly we peg the fw cache to the device via devres *iff* the firmware actually was found. We do this so that we don't try to

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-04 Thread Luis R. Rodriguez
On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. True, but also more importantly we peg the fw cache to the device via devres *iff* the firmware actually was found. We do this so that we don't try to

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-04 Thread Greg KH
On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firmware() can still find cached firmware, >

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-04 Thread Greg KH
On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firmware() can still find cached firmware, >

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-09-15 Thread Kai-Heng Feng
On Tue, Aug 22, 2017 at 12:52 AM, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firmware() can still find

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-09-15 Thread Kai-Heng Feng
On Tue, Aug 22, 2017 at 12:52 AM, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firmware() can still find cached firmware, > but

[PATCH] firmware: add firmware to new device's devres list for second time cache

2017-08-22 Thread Kai-Heng Feng
Currently, firmware will only be chached if assign_firmware_buf() gets called. When a device loses its power or a USB device gets plugged to another port under suspend, request_firmware() can still find cached firmware, but firmware name no longer associates with the new device's devres. So next

[PATCH] firmware: add firmware to new device's devres list for second time cache

2017-08-22 Thread Kai-Heng Feng
Currently, firmware will only be chached if assign_firmware_buf() gets called. When a device loses its power or a USB device gets plugged to another port under suspend, request_firmware() can still find cached firmware, but firmware name no longer associates with the new device's devres. So next