Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check

2019-04-10 Thread Sudeep Holla
On Mon, Mar 25, 2019 at 05:37:22PM +, Steven Price wrote: > of_parse_phandle_with_args() requires the caller to call of_node_put() on > the returned args->np pointer. Otherwise the reference count will remain > incremented. > Good find and thanks for the fix. > However, in this case, since

Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check

2019-03-26 Thread Steven Price
On 26/03/2019 07:23, Mukesh Ojha wrote: > > On 3/25/2019 11:07 PM, Steven Price wrote: >> of_parse_phandle_with_args() requires the caller to call of_node_put() on >> the returned args->np pointer. Otherwise the reference count will remain >> incremented. >> >> However, in this case, since we

Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check

2019-03-26 Thread Mukesh Ojha
On 3/25/2019 11:07 PM, Steven Price wrote: of_parse_phandle_with_args() requires the caller to call of_node_put() on the returned args->np pointer. Otherwise the reference count will remain incremented. However, in this case, since we don't actually use the returned pointer, we can simply

[PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check

2019-03-25 Thread Steven Price
of_parse_phandle_with_args() requires the caller to call of_node_put() on the returned args->np pointer. Otherwise the reference count will remain incremented. However, in this case, since we don't actually use the returned pointer, we can simply pass in NULL. Fixes: aa4f886f3893f ("firmware: