On Mon, Mar 25, 2019 at 03:48:22PM -0500, Kangjie Lu wrote:
You should mark this v2 id you changed any code or commit message or
added any tags. Just FYI for future.
> Thanks for Steven Price's review of this patch. In the current code,
> idr_find won't return NULL because the SCMI_PROTOCOL_BASE
On Fri, Mar 08, 2019 at 10:02:39PM -0600, Kangjie Lu wrote:
> idr_find may return NULL, so check its return value and return an
> error code.
>
I can't imagine a scenario leading to this. Steven has already explained
why, so I won't repeat the same here. Did you hit this issue ?
If so I would
On 25/03/2019 20:48, Kangjie Lu wrote:
> Thanks for Steven Price's review of this patch. In the current code,
There's no need to include a "thanks" message in the commit message -
the "Reviewed-by" tag is sufficient. Please also remember to include an
appropriate version tag in the subject - this
Thanks for Steven Price's review of this patch. In the current code,
idr_find won't return NULL because the SCMI_PROTOCOL_BASE id must
exist. However, it might return NULL in the future code if the check
is on another node while processing the children in subsequent calls
to
On 09/03/2019 04:02, Kangjie Lu wrote:
> idr_find may return NULL, so check its return value and return an
> error code.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/firmware/arm_scmi/driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c
>
> On Mar 8, 2019, at 10:02 PM, Kangjie Lu wrote:
>
> idr_find may return NULL, so check its return value and return an
> error code.
Can someone review this patch? Thanks.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/firmware/arm_scmi/driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
idr_find may return NULL, so check its return value and return an
error code.
Signed-off-by: Kangjie Lu
---
drivers/firmware/arm_scmi/driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/arm_scmi/driver.c
b/drivers/firmware/arm_scmi/driver.c
index
7 matches
Mail list logo
