Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 3:40 AM Sudeep Holla wrote: > > > > > > > > if (xfer->hdr.poll_completion) { > > > > > > - ktime_t stop = ktime_add_ns(ktime_get(), > > > > > > SCMI_MAX_POLL_TO_NS); > > > > > > + ktime_t stop = ktime_add_ns(ktime_get(), 500 * 1000 * > > >

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-11 Thread Sudeep Holla
On Wed, Jun 10, 2020 at 09:45:55PM -0500, Jassi Brar wrote: > On Wed, Jun 10, 2020 at 10:56 AM Sudeep Holla wrote: > > [I admit you can write bigger posts than me, so I am not going to > write a passionate response to each of your paragraphs. > Let's keep it to the point.] > > > > > > if

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Jassi Brar
On Wed, Jun 10, 2020 at 10:56 AM Sudeep Holla wrote: [I admit you can write bigger posts than me, so I am not going to write a passionate response to each of your paragraphs. Let's keep it to the point.] > > > > if (xfer->hdr.poll_completion) { > > > > - ktime_t stop =

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Sudeep Holla
On Wed, Jun 10, 2020 at 10:21:19AM -0500, Jassi Brar wrote: > On Wed, Jun 10, 2020 at 3:23 AM Sudeep Holla wrote: > > > > On Sun, Jun 07, 2020 at 02:30:23PM -0500, jassisinghb...@gmail.com wrote: > > > From: Jassi Brar > > > > > > Currently scmi_do_xfer() submits a message to mailbox api and

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Jassi Brar
On Wed, Jun 10, 2020 at 3:23 AM Sudeep Holla wrote: > > On Sun, Jun 07, 2020 at 02:30:23PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Currently scmi_do_xfer() submits a message to mailbox api and waits > > for an apparently very short time. This works if there are not

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Sudeep Holla
On Sun, Jun 07, 2020 at 02:30:23PM -0500, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > Currently scmi_do_xfer() submits a message to mailbox api and waits > for an apparently very short time. This works if there are not many > messages in the queue already. However, if many clients

[PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-07 Thread jassisinghbrar
From: Jassi Brar Currently scmi_do_xfer() submits a message to mailbox api and waits for an apparently very short time. This works if there are not many messages in the queue already. However, if many clients share a channel and/or each client submits many messages in a row, the timeout value