Re: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-12-21 Thread James Morse
Hi Nicolas, On 03/12/2018 12:25, Nicolas Saenz Julienne wrote: > On Fri, 2018-11-30 at 18:31 +, James Morse wrote: >> On 26/11/2018 12:15, Nicolas Saenz Julienne wrote: >>> After finding a "firmware" dt node arm_sdei tries to match it's >>> compatible string with it. To do so it's calling >>>

Re: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
Hi James, thanks for the review! On Fri, 2018-11-30 at 18:31 +, James Morse wrote: > Hi Nicolas, > > On 26/11/2018 12:15, Nicolas Saenz Julienne wrote: > > After finding a "firmware" dt node arm_sdei tries to match it's > > compatible string with it. To do so it's calling > >

Re: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
Hi James, thanks for the review! On Fri, 2018-11-30 at 18:31 +, James Morse wrote: > Hi Nicolas, > > On 26/11/2018 12:15, Nicolas Saenz Julienne wrote: > > After finding a "firmware" dt node arm_sdei tries to match it's > > compatible string with it. To do so it's calling > >

Re: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-11-30 Thread James Morse
Hi Nicolas, On 26/11/2018 12:15, Nicolas Saenz Julienne wrote: > After finding a "firmware" dt node arm_sdei tries to match it's > compatible string with it. To do so it's calling of_find_matching_node() > which already takes care of decreasing the refcount on the "firmware" > node. We are then

Re: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-11-30 Thread James Morse
Hi Nicolas, On 26/11/2018 12:15, Nicolas Saenz Julienne wrote: > After finding a "firmware" dt node arm_sdei tries to match it's > compatible string with it. To do so it's calling of_find_matching_node() > which already takes care of decreasing the refcount on the "firmware" > node. We are then

[PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-11-26 Thread Nicolas Saenz Julienne
After finding a "firmware" dt node arm_sdei tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again. This patch

[PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-11-26 Thread Nicolas Saenz Julienne
After finding a "firmware" dt node arm_sdei tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again. This patch