Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-07-13 Thread Greg Kroah-Hartman
On Thu, Jul 13, 2017 at 01:44:34AM +0200, Luis R. Rodriguez wrote: > On Tue, Jun 27, 2017 at 10:37:11AM -0700, Bjorn Andersson wrote: > > On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote: > > > Why would we keep it if there is no in-tree user for it? If you want it > > > sometime in the

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-07-13 Thread Greg Kroah-Hartman
On Thu, Jul 13, 2017 at 01:44:34AM +0200, Luis R. Rodriguez wrote: > On Tue, Jun 27, 2017 at 10:37:11AM -0700, Bjorn Andersson wrote: > > On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote: > > > Why would we keep it if there is no in-tree user for it? If you want it > > > sometime in the

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-07-12 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 10:37:11AM -0700, Bjorn Andersson wrote: > On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote: > > Why would we keep it if there is no in-tree user for it? If you want it > > sometime in the future, great, we can revert the deletion then, but > > keeping it around for

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-07-12 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 10:37:11AM -0700, Bjorn Andersson wrote: > On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote: > > Why would we keep it if there is no in-tree user for it? If you want it > > sometime in the future, great, we can revert the deletion then, but > > keeping it around for

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-27 Thread Bjorn Andersson
On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote: > On Mon, Jun 26, 2017 at 01:22:41PM -0700, Bjorn Andersson wrote: > > On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman > > wrote: > > > As Luis pointed out, there are no in-kernel users of > > >

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-27 Thread Bjorn Andersson
On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote: > On Mon, Jun 26, 2017 at 01:22:41PM -0700, Bjorn Andersson wrote: > > On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman > > wrote: > > > As Luis pointed out, there are no in-kernel users of > > > request_firmware_into_buf(), so remove

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-27 Thread Alan Cox
On Mon, 2017-06-26 at 13:22 -0700, Bjorn Andersson wrote: > On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman > wrote: > > > > As Luis pointed out, there are no in-kernel users of > > request_firmware_into_buf(), so remove it, and the now unused > > internal > >

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-27 Thread Alan Cox
On Mon, 2017-06-26 at 13:22 -0700, Bjorn Andersson wrote: > On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman > wrote: > > > > As Luis pointed out, there are no in-kernel users of > > request_firmware_into_buf(), so remove it, and the now unused > > internal > > flag, which simplifies the

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-27 Thread Greg Kroah-Hartman
On Mon, Jun 26, 2017 at 01:22:41PM -0700, Bjorn Andersson wrote: > On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman > wrote: > > As Luis pointed out, there are no in-kernel users of > > request_firmware_into_buf(), so remove it, and the now unused internal > > flag,

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-27 Thread Greg Kroah-Hartman
On Mon, Jun 26, 2017 at 01:22:41PM -0700, Bjorn Andersson wrote: > On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman > wrote: > > As Luis pointed out, there are no in-kernel users of > > request_firmware_into_buf(), so remove it, and the now unused internal > > flag, which simplifies the logic

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-26 Thread Bjorn Andersson
On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman wrote: > As Luis pointed out, there are no in-kernel users of > request_firmware_into_buf(), so remove it, and the now unused internal > flag, which simplifies the logic around buffer handling a bit. > This API was

Re: [PATCH] firmware: remove request_firmware_into_buf()

2017-06-26 Thread Bjorn Andersson
On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman wrote: > As Luis pointed out, there are no in-kernel users of > request_firmware_into_buf(), so remove it, and the now unused internal > flag, which simplifies the logic around buffer handling a bit. > This API was implemented to reduce the

[PATCH] firmware: remove request_firmware_into_buf()

2017-06-23 Thread Greg Kroah-Hartman
As Luis pointed out, there are no in-kernel users of request_firmware_into_buf(), so remove it, and the now unused internal flag, which simplifies the logic around buffer handling a bit. Reported-by: "Luis R. Rodriguez" Signed-off-by: Greg Kroah-Hartman

[PATCH] firmware: remove request_firmware_into_buf()

2017-06-23 Thread Greg Kroah-Hartman
As Luis pointed out, there are no in-kernel users of request_firmware_into_buf(), so remove it, and the now unused internal flag, which simplifies the logic around buffer handling a bit. Reported-by: "Luis R. Rodriguez" Signed-off-by: Greg Kroah-Hartman ---