Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel [SOLVED]

2014-07-11 Thread Helge Deller
On 07/07/2014 05:28 PM, Heiko Carstens wrote: > On Mon, Jul 07, 2014 at 03:54:37PM +0200, Helge Deller wrote: >> Hi Heiko, >>> So for sys_fanotify_mark everything is fine on s390, and probably most other >>> architectures as well. Having a 64 bit syscall parameter indeed does work, >>> if all the a

Re: Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-07 Thread Heiko Carstens
On Mon, Jul 07, 2014 at 03:54:37PM +0200, Helge Deller wrote: > Hi Heiko, > > So for sys_fanotify_mark everything is fine on s390, and probably most other > > architectures as well. Having a 64 bit syscall parameter indeed does work, > > if all the architecture specific details have been correctly

Aw: Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-07 Thread Helge Deller
Hi Heiko, > On Fri, Jul 04, 2014 at 05:12:35PM +0200, Helge Deller wrote: > > This patch affects big endian architectures only. > > > > On those with 32bit userspace and 64bit kernel (CONFIG_COMPAT=y) the > > 64bit mask parameter is correctly constructed out of two 32bit values in > > the compat_

Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-06 Thread John David Anglin
On 6-Jul-14, at 5:15 AM, Heiko Carstens wrote: But for the CONFIG_COMPAT=n case (32bit kernel & userspace), compat_fanotify_mark() isn't used and the fanotify_mark syscall implementation is used directly. In that case the upper and lower 32 bits of the 64bit mask parameter is still swapped

Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-06 Thread Heiko Carstens
On Fri, Jul 04, 2014 at 05:12:35PM +0200, Helge Deller wrote: > This patch affects big endian architectures only. > > On those with 32bit userspace and 64bit kernel (CONFIG_COMPAT=y) the > 64bit mask parameter is correctly constructed out of two 32bit values in > the compat_fanotify_mark() functio

Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-04 Thread Helge Deller
Hi Heinrich, On 07/04/2014 06:48 PM, Heinrich Schuchardt wrote: > On 04.07.2014 17:12, Helge Deller wrote: >> This patch affects big endian architectures only. >> >> On those with 32bit userspace and 64bit kernel (CONFIG_COMPAT=y) the >> 64bit mask parameter is correctly constructed out of two 32b

Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-04 Thread Heinrich Schuchardt
On 04.07.2014 17:12, Helge Deller wrote: This patch affects big endian architectures only. On those with 32bit userspace and 64bit kernel (CONFIG_COMPAT=y) the 64bit mask parameter is correctly constructed out of two 32bit values in the compat_fanotify_mark() function and then passed as 64bit pa

[PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-04 Thread Helge Deller
This patch affects big endian architectures only. On those with 32bit userspace and 64bit kernel (CONFIG_COMPAT=y) the 64bit mask parameter is correctly constructed out of two 32bit values in the compat_fanotify_mark() function and then passed as 64bit parameter to the fanotify_mark() syscall. Bu