Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

2007-11-07 Thread Muli Ben-Yehuda
On Wed, Nov 07, 2007 at 11:04:41AM -0800, Ray Lee wrote: > On Nov 7, 2007 10:50 AM, Roel Kluin <[EMAIL PROTECTED]> wrote: > > If count reaches zero, the loop ends, but the postfix decrement > > still subtracts: testing for 'count == 0' will not work. > > > > Signed-off-by: Roel Kluin <[EMAIL PROT

Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

2007-11-07 Thread Ray Lee
On Nov 7, 2007 10:50 AM, Roel Kluin <[EMAIL PROTECTED]> wrote: > If count reaches zero, the loop ends, but the postfix decrement still > subtracts: > testing for 'count == 0' will not work. > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/sound/oss/trident.c b/sound/oss/tride

Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

2007-11-07 Thread Roel Kluin
Ray Lee wrote: > On Nov 7, 2007 10:34 AM, Roel Kluin <[EMAIL PROTECTED]> wrote: >> If count reaches zero, the loop ends, but the postfix decrement subtracts it. >> so, testing for 'count == 0' will not work. >> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >> --- >> diff --git a/sound/oss/triden

Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

2007-11-07 Thread Ray Lee
On Nov 7, 2007 10:34 AM, Roel Kluin <[EMAIL PROTECTED]> wrote: > If count reaches zero, the loop ends, but the postfix decrement subtracts it. > so, testing for 'count == 0' will not work. > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/sound/oss/trident.c b/sound/oss/trident

[PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

2007-11-07 Thread Roel Kluin
If count reaches zero, the loop ends, but the postfix decrement subtracts it. so, testing for 'count == 0' will not work. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/sound/oss/trident.c b/sound/oss/trident.c index 96adc47..94b5fb4 100644 --- a/sound/oss/trident.c +++ b/sound/oss